New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User menu is narrower on Summary page #3872

Closed
ebruchez opened this Issue Dec 31, 2018 · 2 comments

Comments

Projects
2 participants
@ebruchez
Copy link
Collaborator

ebruchez commented Dec 31, 2018

Detail/Home:

screen shot 2018-12-31 at 3 50 48 pm

Summary:

screen shot 2018-12-31 at 3 50 41 pm

@avernet

This comment has been minimized.

Copy link
Collaborator

avernet commented Jan 21, 2019

The menu is in an ul.dropdown-menu, with position: absolute. It has a min-width: 160px, but the width on the detail page is 177px:

  • On the summary page, without the min-width: 160px it becomes even narrower.
  • On the detail page, removing the min-width: 160px doesn't make a difference.

@avernet avernet closed this in 3ccdcc1 Jan 21, 2019

@avernet

This comment has been minimized.

Copy link
Collaborator

avernet commented Jan 21, 2019

  • Bootstrap sets a white-space: nowrap on the menu items.
  • Our form-runner-base.less overrides it to normal for XForms outputs.
  • Our grid.less overrides it to nowrap, for the dropdown manu inside the grid.

Since grid.less isn't included for the summary page, the text wraps on the summary page. Since the code in grid.less isn't specific to grids (and it makes sense this way), I'm moving it to form-runner-base.less, and this way it also applies to the dropdown menu on the summary page.

Man… so much time wasted on such an insignificant issue!

@avernet avernet moved this from To do to Done in Orbeon Forms 2018.2.1 Jan 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment