New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login page hardcodes path to /orbeon context #3876

Closed
ebruchez opened this Issue Jan 2, 2019 · 3 comments

Comments

Projects
2 participants
@ebruchez
Copy link
Collaborator

ebruchez commented Jan 2, 2019

See:

<form action="/orbeon/j_security_check" method="post">

This prevents login from working on prod.orbeon.com.

@ebruchez ebruchez added the Form Runner label Jan 2, 2019

@ebruchez ebruchez changed the title Login page hardcodes path to /orbeon contet Login page hardcodes path to /orbeon context Jan 5, 2019

@ebruchez ebruchez added this to To do in Orbeon Forms 2018.2.1 Jan 9, 2019

@avernet

This comment has been minimized.

Copy link
Collaborator

avernet commented Jan 19, 2019

For this we need to know what the context path is (aka path info), and this on the client.

We have a similar need in the TinyMCE code: in that case we produce a link in the markup (see below), then in JavaScript go find that link and extract the part we're interested in.

<xh:a
    f:url-type="resource"
    href="/xbl/orbeon/tinymce/js/tinymce1b713b2e6d7fd45753f4b8a6270b776e.js"
    class="tinymce-base-url xforms-hidden"/>

We could move this capability to the XForms level, and have the server send this info to the client, say in orbeonInitData, instead of generating a dummy link in the page.

@ebruchez

This comment has been minimized.

Copy link
Collaborator Author

ebruchez commented Jan 21, 2019

@avernet The login page an XForms page? If so, we already have some paths in there and we could add one.

Also, since the login page is unlikely to be embedded, we could just produce the context path.

@ebruchez

This comment has been minimized.

Copy link
Collaborator Author

ebruchez commented Jan 22, 2019

Or, since we pass the username/password in the action, we could also pass the submission path at that time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment