New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fr:date: entering letters shows the current date #3877

Closed
ebruchez opened this Issue Jan 2, 2019 · 3 comments

Comments

Projects
2 participants
@ebruchez
Copy link
Collaborator

ebruchez commented Jan 2, 2019

This is not desired as if the user make a typo the date will be set anyway.

screen shot 2019-01-02 at 2 52 56 pm

screen shot 2019-01-02 at 2 52 59 pm

@avernet

This comment has been minimized.

Copy link
Collaborator

avernet commented Jan 19, 2019

I can reproduce this in their sandbox as well, so this isn't specific to our integration. For now I've posted a question about this in their discussion group.

@ebruchez ebruchez moved this from To do to To review in Orbeon Forms 2018.2.1 Jan 22, 2019

@avernet

This comment has been minimized.

Copy link
Collaborator

avernet commented Jan 23, 2019

In Date.xformsGetValue(), we call the date picker's getDate() function, which tries to parse the date "no matter what", and this even when setting forceParse to false (the default is true).

@avernet

This comment has been minimized.

Copy link
Collaborator

avernet commented Jan 24, 2019

  • When parsing, don't take 1a/24/2019 to be January 24, 2019 (because of the a there in the middle)
  • If users enter gaga and tabs out, don't set the field value to the current date
  • If users enter gaga in the field, and open the date picker, don't select the current date

@avernet avernet closed this in 2fcdf57 Jan 24, 2019

@ebruchez ebruchez moved this from To review to Done in Orbeon Forms 2018.2.1 Jan 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment