Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy portlet and embedding JARs cause class loading error #4001

Closed
ebruchez opened this issue Mar 22, 2019 · 8 comments

Comments

Projects
2 participants
@ebruchez
Copy link
Collaborator

commented Mar 22, 2019

@ebruchez ebruchez self-assigned this Mar 22, 2019

@ebruchez ebruchez added this to To review in Orbeon Forms 2019.1 via automation Mar 22, 2019

@ebruchez ebruchez added this to To do in Orbeon Forms 2018.2.3 via automation Mar 22, 2019

@ebruchez

This comment has been minimized.

Copy link
Collaborator Author

commented Mar 22, 2019

This seems to have happened between 2018.2.1 and 2018.2.2.

@ebruchez

This comment has been minimized.

Copy link
Collaborator Author

commented Mar 22, 2019

Well, there is a problem, but it seems to happen post 2018.2.2. The 2018.2.2 proxy portlet has org/orbeon/private/apache/http/HttpRequestInterceptor.class as expected. There should be no code looking for org/apache/http/HttpRequestInterceptor.

@ebruchez

This comment has been minimized.

Copy link
Collaborator Author

commented Mar 29, 2019

Hoping that #4009 addresses the problem.

@ebruchez ebruchez changed the title proxy-portlet.jar is missing classes Proxy portlet and embedding JARs cause class loading error Apr 15, 2019

@ebruchez ebruchez added this to To do in Orbeon Forms 2018.2.3 via automation Apr 15, 2019

@ebruchez

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 15, 2019

Reproducing this with the embedding JAR as well. So we need a better solution.

@ebruchez

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 16, 2019

Given that #4009 works, it might just be that our version of jarjar is broken. Next step would be to try version 1.7.2 (https://mvnrepository.com/artifact/org.pantsbuild/jarjar), used in particular by https://github.com/sbt/sbt-assembly/blob/master/build.sbt.

If that doesn't work:

NOTE: This is called "shaded dependencies" these days.

@avernet

This comment has been minimized.

Copy link
Collaborator

commented Apr 27, 2019

@ebruchez

This comment has been minimized.

Copy link
Collaborator Author

commented May 2, 2019

Updated to jarjar 1.7.2. I can build the JAR and WAR files locally without problems this way. I can also deploy them with Liferay 7.0 and via embedding.

@ebruchez

This comment has been minimized.

Copy link
Collaborator Author

commented May 2, 2019

Confirming that with a CI build, the issue is now fixed.

@ebruchez ebruchez closed this May 2, 2019

Orbeon Forms 2019.1 automation moved this from To review to Done May 2, 2019

Orbeon Forms 2018.2.3 automation moved this from To do to Done May 2, 2019

ebruchez added a commit that referenced this issue May 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.