Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't add a repetition to repeated section after the last one has been removed #4018

Closed
avernet opened this issue Apr 6, 2019 · 4 comments

Comments

Projects
2 participants
@avernet
Copy link
Collaborator

commented Apr 6, 2019

To reproduce, create a form in Form Builder, open the section settings to mark the section as repeated and say it has no minimum number of repetitions, delete the first repetition, click "Add Another Repetition" and notice that no repetition is added. The same also happens at runtime.

We want to support repeated section with no iterations, for consistency with grids, but if, in a first step, if we don't support them, the "No minimum" radio should be disabled or not be there at all in the "Section Settings".

+1 from user

@ebruchez

This comment has been minimized.

Copy link
Collaborator

commented Apr 22, 2019

Is this related at all to #4032?

@avernet

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 22, 2019

I don't know it it is caused by the same underlying issue, but the steps to reproduce seem different: this issue is about the addition failing if the last repeated section has been removed, while for #4032 you need to have additional constraints ("This works if the top-level repeated section only contains a grid. With a nested section, this doesn't work in a simple case.").

@ebruchez

This comment has been minimized.

Copy link
Collaborator

commented Apr 22, 2019

@avernet Sorry that was more a question to myself ;)

@ebruchez

This comment has been minimized.

Copy link
Collaborator

commented May 3, 2019

This is similar to #3892 which applied to repeated grids.

@ebruchez ebruchez closed this in 4d47426 May 3, 2019

Orbeon Forms 2019.1 automation moved this from To review to Done May 3, 2019

Orbeon Forms 2018.2.3 automation moved this from To do to Done May 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.