Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form Builder control settings: support specifying "no grouping separator" #4024

Closed
ebruchez opened this issue Apr 11, 2019 · 6 comments

Comments

Projects
1 participant
@ebruchez
Copy link
Collaborator

commented Apr 11, 2019

Right now, if you use a blank separator, we remove the attribute on the control, which means that the form default or properties kick in. Instead, we need to support having a blank attribute value in this case (and perhaps others).

The UI must be explicit about it and have a "No separator" option.

@ebruchez ebruchez self-assigned this Apr 11, 2019

@ebruchez ebruchez added this to To do in Orbeon Forms 2018.2.3 via automation Apr 11, 2019

@ebruchez ebruchez added this to To review in Orbeon Forms 2019.1 via automation Apr 11, 2019

@ebruchez

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 11, 2019

@ebruchez

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 12, 2019

Possible +1 from customer.

@ebruchez

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 12, 2019

In NumberSupportJava, we have:

groupingSeparator.headOption getOrElse ','

which is wrong if we want to allow the option of having no grouping separator.

@ebruchez

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 12, 2019

  • Form Builder UI
  • NumberSupportJava
    • support no grouping separator
    • Q: What about entering "1,345" when no separator? Currently, it's an error. We could consider removing unknown characters, or a subset such as punctuation, or even common separators.

@ebruchez ebruchez changed the title Form Builder control settings: support specifying "no separator" Form Builder control settings: support specifying "no grouping separator" Apr 12, 2019

@ebruchez

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 12, 2019

I think that this should only happen to the grouping separator:

  • the decimal separator is required in the grand scheme, so if not specified as an attribute it must be taken from the form or properties
  • it doesn't make sense to have empty prefixes/suffixes
  • having no "digits after decimal" is specified with the value "0"
@ebruchez

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 12, 2019

Correction: for prefixes/suffixes, we need the ability to say "no suffix" or "no prefix" in case a more general one is specified. So we also need a UI for prefix/suffix.

ebruchez added a commit that referenced this issue May 6, 2019

@ebruchez ebruchez closed this May 6, 2019

Orbeon Forms 2019.1 automation moved this from To review to Done May 6, 2019

Orbeon Forms 2018.2.3 automation moved this from To do to Done May 6, 2019

ebruchez added a commit that referenced this issue May 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.