Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPE when opening Form Settings if inspector is enabled #4055

Closed
ebruchez opened this issue May 15, 2019 · 0 comments

Comments

Projects
1 participant
@ebruchez
Copy link
Collaborator

commented May 15, 2019

This happens when producing updates for the custom-properties xxf:dynamic.

Two issues:

  • the inspector should not be included in non-top-level parts
  • even so, there should not be an error

The error happens in XFormsSelect1Control.getInitialItemset, where containingDocument.getStaticOps.getSelect1Analysis(prefixedId) returns null.

This is due to the fact that xxf:dynamic is within a repeat. This means that any call to containingDocument.getStaticOps, which navigates from the bottom up, will find only the first iteration, and is likely to be incorrect. In this case, we should obtain the part in a different way.

@ebruchez ebruchez self-assigned this May 15, 2019

@ebruchez ebruchez added this to To review in Orbeon Forms 2019.1 via automation May 15, 2019

@ebruchez ebruchez added this to To do in Orbeon Forms 2018.2.3 via automation May 15, 2019

ebruchez added a commit that referenced this issue May 15, 2019

ebruchez added a commit that referenced this issue May 15, 2019

@ebruchez ebruchez closed this May 15, 2019

Orbeon Forms 2019.1 automation moved this from To review to Done May 15, 2019

Orbeon Forms 2018.2.3 automation moved this from To do to Done May 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.