Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help doesn't always show correctly in repeated grid #4062

Closed
ebruchez opened this issue May 16, 2019 · 2 comments

Comments

@ebruchez
Copy link
Collaborator

commented May 16, 2019

Reproducing with 2017.2, 2018.1, and 2018.2, but not latest master.

+1 from customer

Is this related to #3871? But that was fixed with 2018.2.1.

@ebruchez

This comment has been minimized.

Copy link
Collaborator Author

commented May 17, 2019

It works with master because new iterations is provided with a full update, while before the server tells the client:

<xxf:control 
    id="section-1-section≡grid-2-grid≡control-1-control⊙1" 
    class="fr-grid-1-1" 
    label="Test Dropdown"
    help="Test Dropdown help"/>
@ebruchez

This comment has been minimized.

Copy link
Collaborator Author

commented May 17, 2019

The xforms-help element is there and updated, but it has the class xforms-disabled. In the template:

<span class="xforms-disabled xforms-help"></span>

and after repeat update:

<span class="xforms-disabledx xforms-help">Test Dropdown help</span>

@ebruchez ebruchez closed this in 8b11ab5 May 17, 2019

@ebruchez ebruchez added this to To review in Orbeon Forms 2019.1 via automation May 17, 2019

@ebruchez ebruchez added this to Todo in Orbeon Forms 2018.1.4 via automation May 17, 2019

@ebruchez ebruchez added this to To do in Orbeon Forms 2018.2.3 via automation May 17, 2019

@ebruchez ebruchez moved this from To review to Done in Orbeon Forms 2019.1 May 17, 2019

@ebruchez ebruchez moved this from Todo to Done in Orbeon Forms 2018.1.4 May 17, 2019

@ebruchez ebruchez moved this from To do to Done in Orbeon Forms 2018.2.3 May 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.