Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New actions: continuations can run multiple times #4068

Closed
ebruchez opened this issue May 23, 2019 · 0 comments
Closed

New actions: continuations can run multiple times #4068

ebruchez opened this issue May 23, 2019 · 0 comments

Comments

@ebruchez
Copy link
Collaborator

@ebruchez ebruchez commented May 23, 2019

We have the following pattern:

<xf:action id="my-action-binding" event="fr-call-user-my-action-action" target="fr-form-model">
    <xf:send submission="my-service-submission"/>
    <xf:action 
        observer="my-service-submission"
        event="xforms-submit-done" 
        context="xxf:instance('fr-service-response-instance')" 
        if="xxf:get-request-attribute('fr-service-continuation-id') = 'my-action-1-id'">
        ...
    </xf:action>
</xf:action>

This means the nested action runs once upon xforms-submit-done, but also runs once the <xf:send> action has completed!

The nested actions must be placed at the top-level, as the "TODO: check whether we need to put this at the top-level" comment in the code indicates!

@ebruchez ebruchez self-assigned this May 23, 2019
@ebruchez ebruchez added this to To review in Orbeon Forms 2019.1 via automation May 23, 2019
@ebruchez ebruchez added this to To do in Orbeon Forms 2018.2.4 via automation May 23, 2019
@ebruchez ebruchez closed this in d2ee3c4 May 23, 2019
Orbeon Forms 2019.1 automation moved this from To review to Done May 23, 2019
Orbeon Forms 2018.2.4 automation moved this from To do to Done May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
1 participant
You can’t perform that action at this time.