Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DMV-14: page shows error when loading #4187

Closed
ebruchez opened this issue Sep 19, 2019 · 5 comments
Closed

DMV-14: page shows error when loading #4187

ebruchez opened this issue Sep 19, 2019 · 5 comments

Comments

@ebruchez
Copy link
Collaborator

@ebruchez ebruchez commented Sep 19, 2019

Simply click from the landing page.

@ebruchez ebruchez self-assigned this Sep 19, 2019
@ebruchez ebruchez added this to To review in Orbeon Forms 2019.1 via automation Sep 19, 2019
@ebruchez ebruchez moved this from To review to In progress in Orbeon Forms 2019.1 Sep 19, 2019
@ebruchez

This comment has been minimized.

Copy link
Collaborator Author

@ebruchez ebruchez commented Sep 20, 2019

This is due to changes to fr:checkbox-input for #4066.

When in a repeated fr:grid, the xf:label nested within the control is moved out of the control and placed in the repeat header, with for attribute. Changes to fr:checkbox-input just copy the xf:label inside the component's implementation, but that element is missing when the control is placed in a repeated grid. So we end up with an xf:item without xf:label.

@ebruchez

This comment has been minimized.

Copy link
Collaborator Author

@ebruchez ebruchez commented Sep 20, 2019

A better fix here would be to do what we used to do: use the lhha custom-lhha modes, but have that apply only to xf:label. Maybe we can introduce a custom-label mode?

@ebruchez

This comment has been minimized.

Copy link
Collaborator Author

@ebruchez ebruchez commented Sep 20, 2019

We might actually want all LHHA to be custom except xf:alert.

@ebruchez

This comment has been minimized.

Copy link
Collaborator Author

@ebruchez ebruchez commented Sep 23, 2019

  • make sure #4066 still works as expected
  • doc separate custom LHHA modes
ebruchez added a commit that referenced this issue Sep 23, 2019
ebruchez added a commit that referenced this issue Sep 23, 2019
ebruchez added a commit that referenced this issue Sep 23, 2019
ebruchez added a commit that referenced this issue Sep 23, 2019
@ebruchez ebruchez moved this from In progress to Done in Orbeon Forms 2019.1 Sep 23, 2019
@ebruchez ebruchez closed this Sep 23, 2019
@ebruchez

This comment has been minimized.

Copy link
Collaborator Author

@ebruchez ebruchez commented Sep 23, 2019

ebruchez added a commit that referenced this issue Sep 23, 2019
ebruchez added a commit that referenced this issue Sep 23, 2019
ebruchez added a commit that referenced this issue Sep 23, 2019
ebruchez added a commit that referenced this issue Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
1 participant
You can’t perform that action at this time.