Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wizard: navigate pages with the keyboard #4210

Closed
ebruchez opened this issue Oct 14, 2019 · 6 comments
Closed

Wizard: navigate pages with the keyboard #4210

ebruchez opened this issue Oct 14, 2019 · 6 comments

Comments

@ebruchez
Copy link
Collaborator

@ebruchez ebruchez commented Oct 14, 2019

Right now, focus takes place when tabbing through the TOC, but it's not possible to activate the page, and therefore switch pages, with the keyboard.

+1 from customer

@ebruchez

This comment has been minimized.

Copy link
Collaborator Author

@ebruchez ebruchez commented Oct 14, 2019

Adding href="#" to <a> tags that are "generated" from xf:trigger with appearance set to minimal solves this problem.

If true, this would be an easy fix indeed.

+1 from customer

@ebruchez ebruchez added this to To review in Orbeon Forms 2020.1 via automation Dec 12, 2019
@ebruchez

This comment has been minimized.

Copy link
Collaborator Author

@ebruchez ebruchez commented Dec 13, 2019

Interestingly, this is a result of #2652. It's interesting that we can't activate the link with the button role right now.

@ebruchez

This comment has been minimized.

Copy link
Collaborator Author

@ebruchez ebruchez commented Dec 13, 2019

I tried, in the DOM, changing the role to link, same thing. Only when we have href="#" does the link activate with the keyboard (Chrome).

@ebruchez

This comment has been minimized.

Copy link
Collaborator Author

@ebruchez ebruchez commented Dec 13, 2019

I would say that not putting href="#" is not very conclusive, at least based on that old SO post that #2652 was referring to. So I think we should keep it and solve the issue this way. I don't know if Total Validator is still in use, but maybe it's no longer relevant. Repeats also handle things differently now, and disabled controls could possibly remove the href if needed.

@ebruchez

This comment has been minimized.

Copy link
Collaborator Author

@ebruchez ebruchez commented Dec 13, 2019

See commit 569584e.

Steps:

  • keep tabindex="0"
  • keep role="button" (changed from link later)
  • re-add href="#"
@ebruchez ebruchez closed this in 8910518 Dec 14, 2019
Orbeon Forms 2020.1 automation moved this from To review to Done Dec 14, 2019
@ebruchez ebruchez removed this from Done in Orbeon Forms 2020.1 Dec 16, 2019
@ebruchez ebruchez added this to Done in Orbeon Forms 2019.2 Dec 16, 2019
@ebruchez ebruchez moved this from Done to In progress in Orbeon Forms 2019.2 Dec 17, 2019
@ebruchez ebruchez reopened this Dec 17, 2019
@ebruchez

This comment has been minimized.

Copy link
Collaborator Author

@ebruchez ebruchez commented Dec 17, 2019

Moving comment to #4302.

@ebruchez ebruchez closed this Dec 17, 2019
Orbeon Forms 2019.2 automation moved this from In progress to Done Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
1 participant
You can’t perform that action at this time.