Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support again `<xf:output>` with text content #4255

Closed
avernet opened this issue Oct 31, 2019 · 1 comment
Closed

Support again `<xf:output>` with text content #4255

avernet opened this issue Oct 31, 2019 · 1 comment

Comments

@avernet
Copy link
Collaborator

@avernet avernet commented Oct 31, 2019

E.g. <xf:output>gaga</xf:output>.

It would be simple enough to, in XFormsOutputControl.scala override the computeValue defined in XFormsValueControl.scala as boundItemOpt map DataModel.getValue getOrElse (throw new IllegalStateException) to get the value from element.getText if boundItemOpt is None.

But maybe we want to do this in the static analysis, as done for the LHHA, in LHHAAnalysis.scala, which evaluates a staticValue, and maybe that LHHA code could be reused.

+1 from customer

@avernet avernet added this to To do in Orbeon Forms 2019.1.1 via automation Oct 31, 2019
@ebruchez ebruchez added this to To do in Orbeon Forms 2019.2 Dec 12, 2019
@ebruchez ebruchez moved this from To do to In progress in Orbeon Forms 2019.2 Dec 17, 2019
@ebruchez

This comment has been minimized.

Copy link
Collaborator

@ebruchez ebruchez commented Dec 17, 2019

  • check <xf:output> within <xf:message>
    • The value of staticControl is null when <xf:output> is nested within LHHA or <xf:message>.
  • handle mediatype="text/html"?
    • Do later. It looks like the extractor/annotator removes the nested markup so we need more changes.
  • unit test
@ebruchez ebruchez closed this Dec 17, 2019
Orbeon Forms 2019.2 automation moved this from In progress to Done Dec 17, 2019
Orbeon Forms 2019.1.1 automation moved this from To do to Done Dec 17, 2019
ebruchez added a commit that referenced this issue Dec 20, 2019
ebruchez added a commit that referenced this issue Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.