Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When inline resources are enabled, don't put `defer` on other scripts #4428

Closed
avernet opened this issue Feb 14, 2020 · 0 comments
Closed

When inline resources are enabled, don't put `defer` on other scripts #4428

avernet opened this issue Feb 14, 2020 · 0 comments

Comments

@avernet
Copy link
Collaborator

@avernet avernet commented Feb 14, 2020

To reproduce, set <property as="xs:boolean" name="oxf.xforms.inline-resources" value="true"/>, load Form Builder, and notice the error Can't find variable: ORBEON on the console.

defer has no effet for inline scripts, so if we defer loading our other scripts, the inline script will run first, and call ORBEON.xforms.InitSupport.initializeFormWithInitData() while ORBEON hasn't been initialized yet.

+1 from customer

@avernet avernet added this to To review in Orbeon Forms 2020.1 via automation Feb 14, 2020
@avernet avernet moved this from To review to To do in Orbeon Forms 2020.1 Feb 14, 2020
@avernet avernet added this to To do in Orbeon Forms 2019.2.1 Feb 14, 2020
@ebruchez ebruchez moved this from To do to Done in Orbeon Forms 2020.1 Feb 14, 2020
@ebruchez ebruchez moved this from To do to Done in Orbeon Forms 2019.2.1 Feb 14, 2020
@ebruchez ebruchez closed this in 5f31e93 Feb 14, 2020
ebruchez pushed a commit that referenced this issue Feb 14, 2020
ebruchez pushed a commit that referenced this issue Feb 14, 2020
ebruchez pushed a commit that referenced this issue Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.