Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dumphex from logging #386

Merged
merged 3 commits into from May 14, 2019

Conversation

Projects
None yet
3 participants
@olgatsib
Copy link
Contributor

commented May 14, 2019

When serialization issues occur the logs get spammed with a lot of garbage data. A single log line stating there was a serialization issue is enough.

Olga added some commits May 14, 2019

@@ -144,7 +144,7 @@ public void onRead(HandlerContext ctx, final Object msg)
catch (Throwable e)
{
logger.error("Error deserializing message", e);
logger.error(InternalUtils.hexDump(32, message.getRight(), 0, message.getRight().length));
logger.debug(InternalUtils.hexDump(32, message.getRight(), 0, message.getRight().length));

This comment has been minimized.

Copy link
@johnou

johnou May 14, 2019

Contributor

Better to wrap this line in isDebugEnabled or the JVM will anyway create a hex dump from the payload and generate unnecessary garbage.

This comment has been minimized.

Copy link
@olgatsib

olgatsib May 14, 2019

Author Contributor

Done

@johnou
Copy link
Contributor

left a comment

left inline comment.

@JoeHegarty JoeHegarty merged commit 9139245 into orbit:master May 14, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.