Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dumphex from logging #386

merged 3 commits into from May 14, 2019
Changes from 2 commits
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.


Just for now

@@ -144,7 +144,7 @@ public void onRead(HandlerContext ctx, final Object msg)
catch (Throwable e)
logger.error("Error deserializing message", e);
logger.error(InternalUtils.hexDump(32, message.getRight(), 0, message.getRight().length));
logger.debug(InternalUtils.hexDump(32, message.getRight(), 0, message.getRight().length));

This comment has been minimized.

Copy link

johnou May 14, 2019


Better to wrap this line in isDebugEnabled or the JVM will anyway create a hex dump from the payload and generate unnecessary garbage.

This comment has been minimized.

Copy link

olgatsib May 14, 2019

Author Contributor


if (msg1 != null)
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.