This repository was archived by the owner on Nov 27, 2023. It is now read-only.
Support key/value pairs for keyvalue store. #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phillmac
suggested changes
Apr 7, 2019
Contributor
phillmac
left a comment
phillmac
left a comment
There was a problem hiding this comment.
Remove redundant json.parse
src/lib/orbitdb-api.js
Outdated
|
|
||
| if (db.type == 'keyvalue') { | ||
| let params = req.body; | ||
| hash = await db.put(params.key, JSON.parse(params.value)) |
Contributor
There was a problem hiding this comment.
JSON.parse is redundant here, the json parser instruction on L14 means that the whole params var is already an unpacked object and no longer a string to be parsed.
hash = await db.put(params.key, params.value)
phillmac
approved these changes
Apr 8, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To test:
create a keyvalue store:
curl http://localhost:3000/db/keyvalue --data 'create=true' --data 'type=keyvalue'write a key/object-value to the store:
curl -X POST http://localhost:3000/db/keyvalue/put -H "Content-Type: application/json" -d '{"key":"mykey","value":"{ name: \"World\" }"}'It should correctly parse the JSON and store a JS object against the key.
A simple:
console.log(db._index)should show the full list correctly written to the keyvalue store.