Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return false from grant / revoke #36

Merged
merged 2 commits into from Jul 17, 2019

Conversation

@phillmac
Copy link
Member

phillmac commented Jul 17, 2019

Return a negative response instead of a NOOP to enable http-api to report non-implemented functions
See orbitdb/orbit-db-http-api#20

Return a negative response instead of a NOOP to enable http-api to report unsuccessful function calls
@shamb0t

This comment has been minimized.

Copy link
Member

shamb0t commented Jul 17, 2019

Thank you @phillmac, looks good! Just a style nitpick, we use standard, ie no semicolons, can you remove them?

@phillmac

This comment has been minimized.

Copy link
Member Author

phillmac commented Jul 17, 2019

@shamb0t Done!

@shamb0t shamb0t merged commit ce7f89d into master Jul 17, 2019
1 check passed
1 check passed
ci/circleci: build Your tests passed on CircleCI!
Details
@shamb0t

This comment has been minimized.

Copy link
Member

shamb0t commented Jul 17, 2019

Thank you @phillmac! 🙏 merged!

@phillmac phillmac mentioned this pull request Aug 28, 2019
@haadcode haadcode deleted the feat/grant-revoke-implemented branch Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.