Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #39. Web3 signer needs to call .getAddress() instead of address… #40

Merged
merged 1 commit into from Jul 25, 2019

Conversation

@ptoner
Copy link
Contributor

ptoner commented Jul 25, 2019

This works in the browser after this:

let provider = new ethers.providers.Web3Provider(web3.currentProvider)
let signer = provider.getSigner(0)

const type = EthIdentityProvider.type

const options = {
    type: type,
    keystore: keystore,
    wallet: signer
}

let identity = await Identities.createIdentity(options)
…. Unit tests pass
@shamb0t shamb0t merged commit a6ee736 into orbitdb:master Jul 25, 2019
1 check passed
1 check passed
ci/circleci Your tests passed on CircleCI!
Details
@shamb0t

This comment has been minimized.

Copy link
Member

shamb0t commented Jul 25, 2019

Thank you @ptoner! Closes #39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.