Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duck typing constructor arg #34

Merged
merged 1 commit into from Jul 31, 2019

Conversation

@aphelionz
Copy link
Contributor

aphelionz commented Jul 30, 2019

If the first argument to new Keystore(store) is:

  1. a valid store object, just use that
  2. a string, use that as the path
  3. null / undefined, use the default path

This allows maximal backwards compatibility with the orbit-db-identity-provider while still letting us move forward with orbit-db-storage-adapter

Coincides with orbitdb/orbit-db-identity-provider#29

Fixing lint and build files
@aphelionz aphelionz force-pushed the fix/duck-typed-constructor branch from 8130997 to 53aed34 Jul 30, 2019
@aphelionz aphelionz merged commit 23b9dd1 into master Jul 31, 2019
4 checks passed
4 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test-browser Your tests passed on CircleCI!
Details
ci/circleci: test-node Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.