Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write Access with id ? #684

Merged
merged 1 commit into from Sep 17, 2019

Conversation

@spartanz51
Copy link
Contributor

spartanz51 commented Sep 17, 2019

No description provided.

@phillmac

This comment has been minimized.

Copy link
Member

phillmac commented Sep 17, 2019

The id is not the public key. The public key is required for access control 🐱

@tabcat

This comment has been minimized.

Copy link
Contributor

tabcat commented Sep 17, 2019

weird, ive always added the id to the accessController.write array

@tabcat

This comment has been minimized.

Copy link
Contributor

tabcat commented Sep 17, 2019

these changes seem correct

@phillmac

This comment has been minimized.

Copy link
Member

phillmac commented Sep 17, 2019

It used to be that the id was the public key, but recently it's become possible to define the public key and id separately, so id !== public key

edit: 2018 isn't so recent

@aphelionz

This comment has been minimized.

Copy link
Contributor

aphelionz commented Sep 17, 2019

Thanks for the PR @spartanz51 .

These changes are indeed correct. You can see the tests here: https://github.com/orbitdb/orbit-db/search?q=%22.identity.id%22&unscoped_q=%22.identity.id%22

There was another discussion about this recently as well, in this PR. You can follow more of the discussion there. orbitdb/orbit-db-access-controllers#31

@aphelionz aphelionz merged commit 4af0ab3 into orbitdb:master Sep 17, 2019
1 check passed
1 check passed
ci/circleci Your tests passed on CircleCI!
Details
@@ -203,7 +203,7 @@ ipfs.on('ready', async () => {
})
```

To give write access to another peer, you'll need to get their public key with some means. They'll need to give you the output of their OrbitDB instance's key: `orbitdb.identity.publicKey`.
To give write access to another peer, you'll need to get their public key with some means. They'll need to give you the output of their OrbitDB instance's key: `orbitdb.identity.id`.

This comment has been minimized.

Copy link
@tabcat

tabcat Sep 17, 2019

Contributor

should probably have changed 'OrbitDB instance's key' to 'OrbitDB instance's id'

@aphelionz

This comment has been minimized.

Copy link
Contributor

aphelionz commented Sep 17, 2019

Fixed it in post ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.