New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write Access with id ? #684
Conversation
The id is not the public key. The public key is required for access control 🐱 |
weird, ive always added the id to the accessController.write array |
these changes seem correct |
It used to be that the id was the public key, but edit: 2018 isn't so recent |
Thanks for the PR @spartanz51 . These changes are indeed correct. You can see the tests here: https://github.com/orbitdb/orbit-db/search?q=%22.identity.id%22&unscoped_q=%22.identity.id%22 There was another discussion about this recently as well, in this PR. You can follow more of the discussion there. orbitdb-archive/orbit-db-access-controllers#31 |
@@ -203,7 +203,7 @@ ipfs.on('ready', async () => { | |||
}) | |||
``` | |||
|
|||
To give write access to another peer, you'll need to get their public key with some means. They'll need to give you the output of their OrbitDB instance's key: `orbitdb.identity.publicKey`. | |||
To give write access to another peer, you'll need to get their public key with some means. They'll need to give you the output of their OrbitDB instance's key: `orbitdb.identity.id`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should probably have changed 'OrbitDB instance's key' to 'OrbitDB instance's id'
Fixed it in post ;) |
No description provided.