Integrate with latest Orbit.js #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pending resolution to orbitjs/orbit#236
Rethink integration
Convert to ember addon
Update orbit.js to #9bcf102
Reintegrate with latest version of orbit
Every model should have a primary `id` field which is no longer defined as a `key`. Keys are now used for tracking remote keys only.
Allow `orbitSchema` to either be injected on creation or to be created as part of EO.Schema creation.
Fixes to the rethink branch
Stores should not create their own schemas. This was backwards.
Require `schema` to be injected onto a Store.
This method should trigger the request flow, and not simply transform the store’s cache.
This was inconsistently implemented across methods that might initiate a transform. Furthermore, the need for a store-wide promise tracker hasn’t been proven. It seems preferable to observe the state of the coordinator and all of its queues.
Transforms are now received via the cache’s patches subscription.
Simply invoke `this.orbitStore.query`.
By placing `type` on each Model instance, models can be inspected for their `type` + `id`. This eliminates the need for `getIdentifier` in queries and transforms.
No need to use get/set on instance-level vars. These can be accessed directly. `identifier` method is no longer necessary.
No need to use get/set on instance-level vars. These can be accessed directly.
Minimize use of get/set on instance-level vars, favoring direct access where possible.
Rethink queries
Requires immutable.js.
This was referenced May 27, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See orbitjs/orbit#299