adding linter eslint and making sure our code is aligned with the rules

set.
orbs-network · Apr 28, 2019 · c2e4532 · c2e4532
1 parent e367049
commit c2e4532
Show file tree

Hide file tree

Showing 16 changed files with 2,396 additions and 88 deletions.
diff --git a/.eslintignore b/.eslintignore
@@ -0,0 +1 @@
+node_modules/
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -0,0 +1,18 @@
+{
+    "env": {
+        "commonjs": true,
+        "es6": true,
+        "node": true
+    },
+    "extends": "eslint:recommended",
+    "globals": {
+        "Atomics": "readonly",
+        "SharedArrayBuffer": "readonly"
+    },
+    "parserOptions": {
+        "ecmaVersion": 2018
+    },
+    "rules": {
+        "no-console": 0
+    }
+}
diff --git a/lib/cli/handlers/create.js b/lib/cli/handlers/create.js
@@ -1,4 +1,3 @@
-const path = require('path');
 const _ = require('lodash');
 
 const { createBoyarConfig } = require('./../boyar/create-config');

diff --git a/lib/cli/handlers/destroy.js b/lib/cli/handlers/destroy.js
@@ -1,5 +1,3 @@
-const path = require('path');
-
 const { logRed, logGreen, getComposeFileOrFlagsHandler } = require('./../methods');
 const { Nebula } = require('./../../../lib/services/nebula');
 const { resolvePath } = require("../../utils/resolve-path");

diff --git a/lib/cli/handlers/network-status.js b/lib/cli/handlers/network-status.js
@@ -2,6 +2,7 @@ const _ = require('lodash');
 
 const { getNodes } = require('../boyar/create-config');
 const { getEndpoint, getStatus } = require('../../metrics');
+const { logRed, logGreen } = require('../methods');
 
 async function status({ configPath, vchain }) {
     if (!configPath || !vchain) {

diff --git a/lib/cli/methods.js b/lib/cli/methods.js
@@ -5,6 +5,8 @@ const readFile = fs.readFileSync;
 const { isEmpty } = require("lodash");
 
 function getComposeFileOrFlagsHandler(handler) {
+    let argsAsFile;
+
     return (argv) => {
         let _argv = {};
 

diff --git a/lib/services/terraform.js b/lib/services/terraform.js
@@ -53,18 +53,18 @@ class Terraform {
         const { name } = cloud;
 
         // SSH key specific variables
-        rows.push({path_to_ssh_pubkey: keys.ssh.path});
+        rows.push({ path_to_ssh_pubkey: keys.ssh.path });
 
         if (!isEmpty(keys.ssh.cidr)) {
-            rows.push({incoming_ssh_cidr_blocks: keys.ssh.cidr});
+            rows.push({ incoming_ssh_cidr_blocks: keys.ssh.cidr });
         }
 
         rows.push(
-            {name: cloud.name},
-            {aws_profile: keys.aws.profile},
-            {region: cloud.region},
-            {instance_type: cloud.instanceType},
-            {instance_count: isInteger(cloud.nodeCount) ? cloud.nodeCount : 2}
+            { name: cloud.name },
+            { aws_profile: keys.aws.profile },
+            { region: cloud.region },
+            { instance_type: cloud.instanceType },
+            { instance_count: isInteger(cloud.nodeCount) ? cloud.nodeCount : 2 }
         );
 
         const boyarKey = 'boyar/config.json';
@@ -73,18 +73,18 @@ class Terraform {
         const boyarConfigUrl = !isEmpty(cloud.bootstrapUrl) ? cloud.bootstrapUrl : `https://${s3Endpoint}.amazonaws.com/${boyarBucket}/${boyarKey}`;
 
         rows.push(
-            {boyar_config_source: `<<EOF\n${JSON.stringify(keys.orbs.boyarConfig)}\nEOF`, multiline: true},
-            {s3_bucket_name: boyarBucket},
-            {s3_boyar_key: boyarKey},
-            {s3_boyar_config_url: boyarConfigUrl}
+            { boyar_config_source: `<<EOF\n${JSON.stringify(keys.orbs.boyarConfig)}\nEOF`, multiline: true },
+            { s3_bucket_name: boyarBucket },
+            { s3_boyar_key: boyarKey },
+            { s3_boyar_config_url: boyarConfigUrl }
         );
 
         if (!isEmpty(keys.orbs.ethereumEndpoint)) {
-            rows.push({ethereum_endpoint: keys.orbs.ethereumEndpoint});
+            rows.push({ ethereum_endpoint: keys.orbs.ethereumEndpoint });
         }
 
         if (!isEmpty(keys.orbs.ethereumTopologyContractAddress)) {
-            rows.push({ethereum_topology_contract_address: keys.orbs.ethereumTopologyContractAddress});
+            rows.push({ ethereum_topology_contract_address: keys.orbs.ethereumTopologyContractAddress });
         }
 
         return map(rows, (row) => {
@@ -328,7 +328,7 @@ class Terraform {
                 if (_item.indexOf(' = ') === -1) {
                     return null;
                 }
-
+                /*eslint no-control-regex: 0*/
                 const item = _item.replace(/[\u001b\u009b][[()#;?]*(?:[0-9]{1,4}(?:;[0-9]{0,4})*)?[0-9A-ORZcf-nqry=><]/g, '');
 
                 const outputParts = item.split(' = ');
@@ -395,7 +395,7 @@ class Terraform {
             });
         });
     }
-};
+}
 
 function log(text, name, op, stdType = 'out') {
     if (!outputs[name]) {
@@ -416,7 +416,7 @@ function log(text, name, op, stdType = 'out') {
         };
         element.ops[op][stdType].push(text);
     }
-};
+}
 
 function base64JSON(source) {
     return Buffer.from(JSON.stringify(source)).toString("base64");

diff --git a/lib/utils/exec.js b/lib/utils/exec.js
@@ -1,7 +1,7 @@
 const { exec: _exec } = require('child-process-promise');
 const { isError } = require('lodash');
 
-const verboseDefaultValue = 'NEBULA_VERBOSE' in process.env && process.env[NEBULA_VERBOSE] === '1' | false;
+const verboseDefaultValue = 'NEBULA_VERBOSE' in process.env && process.env['NEBULA_VERBOSE'] === '1' | false;
 
 async function exec(cmd, opts = {}, verbose = verboseDefaultValue) {
     if (verbose) {