Unix epoch #5
Merged
Unix epoch #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Drop Python 2.6/3.2, support Pypy3, Python3.6 - Upgrade requirements - Simply travis/tox config
|
Changes Unknown when pulling 90a1281 on unix-epoch into ** on develop**. |
|
LGTM! Thanks for the upgrades and cleanup! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@orcasgit/orcas-developers Please review. This should fix the issue with withings notifications not getting processed. The one difference between when we get data for notifications and when we get initial data is that we add a
lastupdatedparameter when getting data for notifications. We pass adatetime.datetimeobject and I'm not entirely sure whatrequeststransforms that to for the request, but according to the Withings API it needs to be a "Date in unix epoch". Thetimestampattribute inarrowworks well in my testing.I'm pulling against develope because it has the latest commits, but I'm thinking after this change is done we should merge to master and publish to PyPI