Fix remove unsafe path joins #913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fruttasecca
changed the title
yannickperrenet
approved these changes
Apr 29, 2022
ricklamers
reviewed
Apr 29, 2022
| @@ -629,7 +623,7 @@ def pipeline_set_notebook_kernels(pipeline_json, pipeline_directory, project_uui | |||
|
|
|||
| if "ipynb" == step["file_path"].split(".")[-1]: | |||
|
|
|||
| notebook_path = os.path.join(pipeline_directory, step["file_path"]) | |||
| notebook_path = safe_join(pipeline_directory, step["file_path"]) | |||
|
|
|||
There was a problem hiding this comment.
I expect this to cause problems because file paths can be relative and point to files above the pipeline directory. We should find all similar resolves of paths that use the pipeline step file path in particular.
There was a problem hiding this comment.
Good catch, will take a look
fruttasecca
force-pushed
the
fix/remove-unsafe-path-join
branch
from
52f70de to
77574c4
Compare
iannbing
reviewed
May 2, 2022
|
|
||
|
|
||
| def is_valid_data_path(path: str): | ||
| return os.path.abspath(os.path.normpath(path)).startswith("/data") |
There was a problem hiding this comment.
@fruttasecca Isn't this line always returning false? os.path.abspath(os.path.normpath(path)) most likely would start with /userdir?
There was a problem hiding this comment.
I propose changing it to
in PR #914. Please review the change and discuss in the said PR. :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #907
Fixes: #906
Credits to @porcupineyhairs for discovery and fix proposal
There are a couple of regressions on
devthat make it not possible to test all edge cases, it's something we will have to look into next week.