You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If my understanding of the promises/A+ specification is correct, it is perfectly fine to reject a promise with undefined reason. In orchestrator however this will lead to the task being accepted as successful, due to this bit of code: r.then(function () { finish(null, 'promise'); }, function(err) { finish(err, 'promise'); });
which calls finish(undefined, 'promise') -- a success callback -- if the promise rejects undefined.
The text was updated successfully, but these errors were encountered:
shkuznetsov
changed the title
Task doesn't fail if returned promise rejects without arguments
Task doesn't fail if returned promise rejects without explicitly defined reason
Mar 11, 2015
shkuznetsov
added a commit
to shkuznetsov/orchestrator
that referenced
this issue
Mar 11, 2015
If my understanding of the promises/A+ specification is correct, it is perfectly fine to reject a promise with undefined reason. In orchestrator however this will lead to the task being accepted as successful, due to this bit of code:
r.then(function () { finish(null, 'promise'); }, function(err) { finish(err, 'promise'); });
which calls finish(undefined, 'promise') -- a success callback -- if the promise rejects undefined.
The text was updated successfully, but these errors were encountered: