Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task doesn't fail if returned promise rejects without explicitly defined reason #64

Open
shkuznetsov opened this issue Mar 11, 2015 · 0 comments

Comments

@shkuznetsov
Copy link

If my understanding of the promises/A+ specification is correct, it is perfectly fine to reject a promise with undefined reason. In orchestrator however this will lead to the task being accepted as successful, due to this bit of code:
r.then(function () { finish(null, 'promise'); }, function(err) { finish(err, 'promise'); });
which calls finish(undefined, 'promise') -- a success callback -- if the promise rejects undefined.

@shkuznetsov shkuznetsov changed the title Task doesn't fail if returned promise rejects without arguments Task doesn't fail if returned promise rejects without explicitly defined reason Mar 11, 2015
shkuznetsov added a commit to shkuznetsov/orchestrator that referenced this issue Mar 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant