Add OP_RETURN into `ord wallet send` #3067

grdddj · 2024-01-30T15:29:35Z

Fixes #3007:

adds a new op-return flag to ord wallet send that allows for sending some smaller data in OP_RETURN

Next steps/improvements:

Possible next steps:

raphjaph · 2024-02-02T21:34:08Z

Could you expand a bit on the use cases for this?

grdddj · 2024-02-29T08:13:59Z

Could you expand a bit on the use cases for this?

The use-case is when transferring the inscription between addresses, create some possibility to add some metadata/info to the transfer itself.

Concrete example:

inscriptions are held by a service in one wallet, but "owned" by multiple customers of this service (on different addresses)
the service allows for on-chain transfer of these inscriptions/certificates, so the transfer of ownership is transparent and verifiable
OP_RETURN adds the nice possibility to specify e.g. the price in BTC that one user paid to buy the certificate from the other user
the idea is that these OP-returns will be nicely visible e.g. on mempool.space (in the future maybe even in ord explorer) and will add more transparency to the transfer (or any other on-chain action)

Marked it as a draft for now, hopefully, I will have time to finish it soon. Thanks :)

raphjaph · 2024-03-22T21:47:31Z

src/subcommand/wallet/send.rs

+
+    if let Some(op_return) = self.op_return {
+      // TODO: improve the check for checking byte-length
+      assert!(op_return.len() <= 80);


Suggested change

assert!(op_return.len() <= 80);

assert!(op_return.len() <= 82);

raphjaph · 2024-03-22T21:47:46Z

src/wallet/transaction_builder.rs

+use bitcoin::blockdata::script::PushBytesBuf;
+


Inline with the other imports

WIP - op-return when sending

ebffb06

grdddj marked this pull request as draft February 29, 2024 08:01

raphjaph reviewed Mar 22, 2024

View reviewed changes

Provide feedback

	assert!(op_return.len() <= 80);
	assert!(op_return.len() <= 82);