Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make top spacing consistent for html/iPad #17

Merged
merged 1 commit into from Mar 2, 2015
Merged

Make top spacing consistent for html/iPad #17

merged 1 commit into from Mar 2, 2015

Conversation

codingisacopingstrategy
Copy link
Contributor

Hello,

The padding in the HTML body is currently inconsistent for the desktop, tablet and phone media queries, and on those pages with not enough vertical space above (like the TOC page in the default contents) text becomes unreadable on the tablet variant.

The small change introduced in this pull request makes the top spacing consistent.

For reference, this is current behaviour:

Desktop:
screen shot 2015-03-01 at 22 25 13

Tablet:
screen shot 2015-03-01 at 22 25 03

Phone:
screen shot 2015-03-01 at 22 24 52

Thanks,

@sandersk
Copy link

sandersk commented Mar 2, 2015

Looks good. Thanks for the fix, @codingisacopingstrategy

@sandersk sandersk closed this Mar 2, 2015
@sandersk sandersk reopened this Mar 2, 2015
sandersk pushed a commit that referenced this pull request Mar 2, 2015
Make top spacing consistent for html/iPad
@sandersk sandersk merged commit 20cd4eb into oreillymedia:master Mar 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants