You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
M-; (org-roam-get-keyword "TITLE" (org-roam-node-file (org-roam-node-at-point))) and get a garbled string.
To fix that problem, I modified the function. And it works for me.
(defunorg-roam-get-keyword (name&optionalfilebound)
"Return keyword property NAME from an org FILE.FILE defaults to current file.Only scans up to BOUND bytes of the document."
(unless bound
(setq bound 1024))
(if file
(with-temp-buffer;; from insert-file-contents-literally to insert-file-contents
(insert-file-contents file nil0 bound)
(org-roam--get-keyword name))
(org-roam--get-keyword name bound)))
I'm wondering if the "literally" function is essential for performance reasons?
The text was updated successfully, but these errors were encountered:
I wouldn't say it's performance-critical, since nothing in the repo calls org-roam-get-keyword. It was a nice-to-have, but now that we know it doesn't work with CJK characters it should definitely be changed.
I got this problem in Doom Emacs: doomemacs/doomemacs#5293, and I finally fixed this by modifying the definition of function
org-roam-get-keyword
To reproduce:
M-; (org-roam-get-keyword "TITLE" (org-roam-node-file (org-roam-node-at-point)))
and get a garbled string.To fix that problem, I modified the function. And it works for me.
I'm wondering if the "literally" function is essential for performance reasons?
The text was updated successfully, but these errors were encountered: