Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(perf): use sqlite transactions, and GC less #847

Merged
merged 12 commits into from Jun 19, 2020
Merged

Conversation

jethrokuan
Copy link
Member

@jethrokuan jethrokuan commented Jun 18, 2020

Motivation for this change

We use sqlite transactions to commit changes into the database, rather than storing all the data in a list before running one big insert. Hopefully this gives a noticeable perf boost.

Also add org-roam-db-gc-threshold, which defaults to a large number. This allows expensive operations like org-roam-db-build-cache to execute faster (on 1000 files, cuts execution time from 70s to 50s).

Ref #834

We use sqlite transactions to commit changes into the database, rather
than storing all the data in a list before running one big insert.
Hopefully this gives a noticeable perf boost.
@jethrokuan jethrokuan requested a review from zaeph June 18, 2020 11:17
@jethrokuan jethrokuan changed the title (perf): use sqlite transactions (perf): use sqlite transactions, and GC less Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant