Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add search-forward and skip-chars-forward functions #36

Merged
merged 2 commits into from Jun 8, 2019
Merged

Add search-forward and skip-chars-forward functions #36

merged 2 commits into from Jun 8, 2019

Conversation

tskinn
Copy link
Contributor

@tskinn tskinn commented Jun 8, 2019

There are a good amount of built in functions we will need to implement most, if not all of the parser functions. Here is my crack at adding these two. search-forward is weird because it supports searching backward but I didn't bother implementing that here. I probably should add some more tests and tidy up but thought I would open a PR and maybe get some feedback first.

Copy link
Collaborator

@ngortheone ngortheone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ngortheone ngortheone merged commit e158275 into org-rs:master Jun 8, 2019
@ngortheone
Copy link
Collaborator

@tskinn Thanks!
I think I will need to setup Travis to run automated tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants