ci: Remove helm dependency

org-trello · Nov 22, 2016 · 5213949 · 5213949
1 parent 75ca05b
commit 5213949
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 9 deletions.
diff --git a/Cask b/Cask
@@ -30,5 +30,4 @@
  (depends-on "undercover")
  (depends-on "ert")
  (depends-on "ert-expectations")
- (depends-on "el-mock")
- (depends-on "helm"))
+ (depends-on "el-mock"))
diff --git a/test/org-trello-input-test.el b/test/org-trello-input-test.el
@@ -1,18 +1,20 @@
 (require 'org-trello-input)
 
-(ert-deftest test-orgtrello-input-read-string-completion ()
+(ert-deftest test-orgtrello-input-ido-read-string-completion ()
   (should (eq :res-with-ido
               (let ((org-trello-input-completion-mechanism 'default))
                 (with-mock
                   (mock (ido-completing-read :prompt :choices nil 'do-match) => :res-with-ido)
-                  (orgtrello-input-read-string-completion :prompt :choices)))))
-  ;; cask declares helm as test dependency
-  (should (eq :res-with-helm
-              (let ((org-trello-input-completion-mechanism 'other))
-                (with-mock
-                  (mock (helm-comp-read :prompt :choices) => :res-with-helm)
                   (orgtrello-input-read-string-completion :prompt :choices))))))
 
+(if (boundp 'helm-comp-read)
+    (ert-deftest test-orgtrello-input-helm-read-string-completion ()
+      (should (eq :res-with-helm
+                  (let ((org-trello-input-completion-mechanism 'other))
+                    (with-mock
+                      (mock (helm-comp-read :prompt :choices) => :res-with-helm)
+                      (orgtrello-input-read-string-completion :prompt :choices)))))))
+
 (ert-deftest test-orgtrello-input-read-not-empty ()
   (should (equal "something"
                  (with-mock