New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make image thumbnail size configurable #226

Merged
merged 1 commit into from Jun 12, 2017

Conversation

Projects
None yet
3 participants
@cpbotha
Contributor

cpbotha commented Feb 8, 2017

When org2blog/wp-image-thumbnails is true, org2blog up to now would
default to the "medium" thumbnail of 300px. However, wordpress
automatically makes a number of thumbnails automatically at upload.

This new custom variable org2blog/wp-image-thumbnail-size allows you
to select which size thumbnail you want: thumbnail, medium,
medium_large (since wordpress 4.4) or large.

Make image thumbnail size configurable
When org2blog/wp-image-thumbnails is true, org2blog up to now would
default to the "medium" thumbnail of 300px. However, wordpress
automatically makes a number of thumbnails automatically at upload.

This new custom variable org2blog/wp-image-thumbnail-size allows you
to select which size thumbnail you want: thumbnail, medium,
medium_large (since wordpress 4.4) or large.
@punchagan

This comment has been minimized.

Show comment
Hide comment
@punchagan

punchagan Jun 12, 2017

Member

@grettke looks like you are actively working on org2blog. Would you mind looking into this PR, please?

Member

punchagan commented Jun 12, 2017

@grettke looks like you are actively working on org2blog. Would you mind looking into this PR, please?

@punchagan punchagan merged commit 256c0af into org2blog:master Jun 12, 2017

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
@punchagan

This comment has been minimized.

Show comment
Hide comment
@punchagan

punchagan Jun 12, 2017

Member

Nevermind, it turned out to be a pretty simple change. So, I merged it.

Sorry @cpbotha that it was left hanging for so long!

Member

punchagan commented Jun 12, 2017

Nevermind, it turned out to be a pretty simple change. So, I merged it.

Sorry @cpbotha that it was left hanging for so long!

@grettke

This comment has been minimized.

Show comment
Hide comment
@grettke

grettke Jun 12, 2017

Collaborator

Thank you @cpbotha and @punchagan .

Collaborator

grettke commented Jun 12, 2017

Thank you @cpbotha and @punchagan .

@cpbotha

This comment has been minimized.

Show comment
Hide comment
@cpbotha

cpbotha Jun 12, 2017

Contributor

Thank you very much everyone, much appreciated!!

Contributor

cpbotha commented Jun 12, 2017

Thank you very much everyone, much appreciated!!

@cpbotha cpbotha deleted the cpbotha:cpb-configure-wp-thumbnail-size branch Jun 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment