Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relations with oneway=yes are wrongly converting roads to one-way #8246

Open
RedAuburn opened this issue May 21, 2024 · 7 comments
Open

Relations with oneway=yes are wrongly converting roads to one-way #8246

RedAuburn opened this issue May 21, 2024 · 7 comments
Labels
Bug Something isn't working Generator Related to generator tool. Map Data OpenStreetMap data related issues Routing Route building issues, e.g. valid route, valid ETA

Comments

@RedAuburn
Copy link
Sponsor Member

There are around 2000 relations with oneway=yes tagging.
https://overpass-turbo.eu/s/1LQf

as reported on telegram, this road:
https://www.openstreetmap.org/way/6363768
is part of this relation:
https://www.openstreetmap.org/relation/1473170

the road incorrectly inherits oneway=yes from the relation.

@RedAuburn RedAuburn added Bug Something isn't working Map Data OpenStreetMap data related issues Routing Route building issues, e.g. valid route, valid ETA Generator Related to generator tool. labels May 21, 2024
@RedAuburn
Copy link
Sponsor Member Author

ah ok, 1911 uses are on relations with type=route (and only 2 on 'type=restriction'). The fix would be to not apply surface/oneway etc tags from route relations.

@RedAuburn RedAuburn changed the title Relations with oneway=yes are converting unrelated roads to one-way Relations with oneway=yes are wrongly converting roads to one-way May 22, 2024
@muralito
Copy link
Contributor

Which is the semantic of tag oneway=yes on a relation element? It's not specified in the wiki https://wiki.openstreetmap.org/wiki/Key:oneway

@pastk
Copy link
Contributor

pastk commented May 23, 2024

Probably we shouldn't infer all tags from relations, but should apply whitelisted ones only.
@vng

@vng
Copy link
Member

vng commented May 23, 2024

Good catch. We don't take all tags, but the current logic is very complicated and aims to patch OSM mapping traits.
See RelationTagsWay::Process

@vng
Copy link
Member

vng commented May 23, 2024

I will put a crutch, but I still don't have a clear vision of OSM mapping here.

  1. For example, this https://www.openstreetmap.org/relation/12126834 I suspect that oneway=yes should be taken from this kind of relation (route=ferry). I see a contradiction here with route=road.
  2. Should we take "surface" from route=road relations?

@pastk
Copy link
Contributor

pastk commented May 23, 2024

1. For example, this https://www.openstreetmap.org/relation/12126834 I suspect that oneway=yes should be taken from this kind of relation (route=ferry).

Nope, here is a "backward" route that uses the same way: https://www.openstreetmap.org/relation/12234840

2. Should we take "surface" from route=road relations?

I think its mistagging.

@mvgorcum
Copy link

This is still an issue for me, since I get weird routes when using organicmaps for navigation in this area.

Note that openstreetmap itself and also osmand don't inherit oneway on these streets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Generator Related to generator tool. Map Data OpenStreetMap data related issues Routing Route building issues, e.g. valid route, valid ETA
Projects
None yet
Development

No branches or pull requests

5 participants