-
-
Notifications
You must be signed in to change notification settings - Fork 964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[strings] some Hindi translations #4266
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! There are also data/strings/sounds.txt and iphone/plist.txt
@j13m126 do you read Hindi? |
I do not, no. But I guess a bad translation is better than no translation. Also, I translated back some words into a third language I know for homonyms like bank. |
I am not sure about that. Let's wait for somebody who can review. |
@jaivsh please take a look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Proofread Hindi translations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are the changes suggested by pidwid. Some have already been corrected, so please let me know if I should add these suggestions to the search terms or also replace them. @Saurmandal
Folks, why do you use spreadsheets here? How can we improve this process? |
14ab757
to
013998d
Compare
Alright, I added a few interface strings, translated search categories and made sure they match categories.txt translations. I tested in on my Pixel 6, running Android 14. Switching phones and also the apps language. I could also enable and hear TTS in hindi. But only on my phone, not on my samsung s6 lite tablet (Android 13). Hindi wasn't an option there. Countries etc. in the map download section are currently not showing the hindi names, even though I provided some in countries_names.txt. If you need any more important interface strings, let me know, otherwise I'd like to leave it as is. |
8100867
to
aa3af2c
Compare
rebased |
Let's finish and merge this PR. Could you please re-base it again? |
Rebase is not enough :( |
d95fada
to
27a20a2
Compare
Right, I forgot. Thanks! |
@biodranik ready to merge |
@vng PTAL and merge if it's ok with a postfix if necessary.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for such a great contribution!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we sure that regenerated strings are ok here?
- I don't see android strings file
- iOS localization file has a lot of English strings
Signed-off-by: Lukas Kronberger <j13m126@posteo.de> [strings] Fixed mistake with he Signed-off-by: Alexander Borsuk <me@alex.bio> [strings] Regenerated hi for iOS Signed-off-by: Alexander Borsuk <me@alex.bio>
Signed-off-by: Alexander Borsuk <me@alex.bio>
27a20a2
to
0a11e75
Compare
@Jean-BaptisteC can you please check if Hindi is working on Android, and also check if each of the search categories works (categories.txt matches types_strings.txt)? |
Translations and searches in Hindi works on Android |
Signed-off-by: Alexander Borsuk <me@alex.bio>
@j13m126 thank you for your work! There are still many untranslated strings left. Can you please review the strings.txt file again and add the missing translations? Or build OM from source and see which names are not yet translated? |
Sure, I'll have a look at it. 👍 |
I used wikidata to translate a few strings into Hindi.
Here is the query for wikidata query service I used to get the country names:
SELECT ?country ?name_en ?name_hi WHERE { ?country wdt:P31 wd:Q3624078. ?country rdfs:label ?name_en. ?country rdfs:label ?name_hi. FILTER (LANG(?name_en) = 'en') FILTER (LANG(?name_hi) = 'hi') }
For the states of India I replaced Q3624078 with Q12443800 in the query above.
For the amenites, shops and cuisines (d70afd0) I used Google Translate exclusively, wikidata wasn't helpful here.
Signed-off-by: Lukas Kronberger j13m126@posteo.de