Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[strings] some Hindi translations #4266

Merged
merged 3 commits into from
Jan 16, 2024
Merged

Conversation

j13m126
Copy link
Contributor

@j13m126 j13m126 commented Jan 12, 2023

I used wikidata to translate a few strings into Hindi.

Here is the query for wikidata query service I used to get the country names:

SELECT ?country ?name_en ?name_hi WHERE { ?country wdt:P31 wd:Q3624078. ?country rdfs:label ?name_en. ?country rdfs:label ?name_hi. FILTER (LANG(?name_en) = 'en') FILTER (LANG(?name_hi) = 'hi') }

For the states of India I replaced Q3624078 with Q12443800 in the query above.

For the amenites, shops and cuisines (d70afd0) I used Google Translate exclusively, wikidata wasn't helpful here.

Signed-off-by: Lukas Kronberger j13m126@posteo.de

@rtsisyk rtsisyk requested a review from a team January 15, 2023 11:01
Copy link
Member

@biodranik biodranik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! There are also data/strings/sounds.txt and iphone/plist.txt

@biodranik
Copy link
Member

@j13m126 do you read Hindi?

@j13m126
Copy link
Contributor Author

j13m126 commented Jan 15, 2023

@j13m126 do you read Hindi?

I do not, no. But I guess a bad translation is better than no translation. Also, I translated back some words into a third language I know for homonyms like bank.

@rtsisyk
Copy link
Member

rtsisyk commented Jan 15, 2023

I guess a bad translation is better than no translation

I am not sure about that. Let's wait for somebody who can review.

@rtsisyk
Copy link
Member

rtsisyk commented Jan 29, 2023

@jaivsh please take a look

@j13m126
Copy link
Contributor Author

j13m126 commented Feb 3, 2023

I wrote a post on reddit asking for help with proofreading and, thanks to Pidwid, already got some feedback on shops. He said he will do amenities soon.

@rtsisyk
Copy link
Member

rtsisyk commented Feb 4, 2023

I wrote a post on reddit asking for help with proofreading and, thanks to Pidwid, already got some feedback on shops. He said he will do amenities soon.

Requested access, thanks! Could you please add Suggestions to this PR?

image

@j13m126
Copy link
Contributor Author

j13m126 commented Feb 4, 2023

I wrote a post on reddit asking for help with proofreading and, thanks to Pidwid, already got some feedback on shops. He said he will do amenities soon.

Requested access, thanks! Could you please add Suggestions to this PR?

image

Access should work now. Will add suggestions in the evening.

Copy link

@Saurmandal Saurmandal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proofread Hindi translations.

data/categories.txt Outdated Show resolved Hide resolved
data/categories.txt Outdated Show resolved Hide resolved
data/categories.txt Outdated Show resolved Hide resolved
data/categories.txt Outdated Show resolved Hide resolved
data/categories.txt Outdated Show resolved Hide resolved
data/categories.txt Outdated Show resolved Hide resolved
data/categories_cuisines.txt Outdated Show resolved Hide resolved
data/categories_cuisines.txt Outdated Show resolved Hide resolved
data/categories_cuisines.txt Outdated Show resolved Hide resolved
data/categories_cuisines.txt Outdated Show resolved Hide resolved
Copy link
Contributor Author

@j13m126 j13m126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are the changes suggested by pidwid. Some have already been corrected, so please let me know if I should add these suggestions to the search terms or also replace them. @Saurmandal

data/strings/types_strings.txt Outdated Show resolved Hide resolved
data/strings/types_strings.txt Outdated Show resolved Hide resolved
data/strings/types_strings.txt Outdated Show resolved Hide resolved
data/strings/types_strings.txt Outdated Show resolved Hide resolved
data/strings/types_strings.txt Outdated Show resolved Hide resolved
data/strings/types_strings.txt Outdated Show resolved Hide resolved
data/strings/types_strings.txt Outdated Show resolved Hide resolved
data/strings/types_strings.txt Outdated Show resolved Hide resolved
data/strings/types_strings.txt Outdated Show resolved Hide resolved
data/strings/types_strings.txt Outdated Show resolved Hide resolved
@rtsisyk
Copy link
Member

rtsisyk commented Feb 8, 2023

Folks, why do you use spreadsheets here? How can we improve this process?

@biodranik
Copy link
Member

There is an easier way to proof-read and fix translations by anyone who does not know how to work with Github and add suggestions here.
You can download these text files and edit them manually, and then send them back to us in a .zip archive at translations@organicmaps.app, or attach them here into a comment:

  1. https://raw.githubusercontent.com/organicmaps/organicmaps/b3e8c4e87ce9ef9c5d0dabb3b7b40a82cc8bc5bc/data/categories.txt
  2. https://raw.githubusercontent.com/organicmaps/organicmaps/b3e8c4e87ce9ef9c5d0dabb3b7b40a82cc8bc5bc/data/categories_cuisines.txt
  3. https://raw.githubusercontent.com/organicmaps/organicmaps/b3e8c4e87ce9ef9c5d0dabb3b7b40a82cc8bc5bc/data/countries_names.txt
  4. https://raw.githubusercontent.com/organicmaps/organicmaps/b3e8c4e87ce9ef9c5d0dabb3b7b40a82cc8bc5bc/data/strings/strings.txt
  5. https://raw.githubusercontent.com/organicmaps/organicmaps/b3e8c4e87ce9ef9c5d0dabb3b7b40a82cc8bc5bc/data/strings/brands_strings.txt
  6. https://raw.githubusercontent.com/organicmaps/organicmaps/b3e8c4e87ce9ef9c5d0dabb3b7b40a82cc8bc5bc/data/strings/sound.txt
  7. https://raw.githubusercontent.com/organicmaps/organicmaps/b3e8c4e87ce9ef9c5d0dabb3b7b40a82cc8bc5bc/data/strings/types_strings.txt
  8. https://raw.githubusercontent.com/organicmaps/organicmaps/b3e8c4e87ce9ef9c5d0dabb3b7b40a82cc8bc5bc/data/plist.txt

Please read the comments in each file and try to understand the context first. The language code for Hindi is hi. Try to follow the sort order when inserting the string. Please don't hesitate to ask if something is not clear. And thank you for your help and efforts! 🙏

iphone/plist.txt Outdated Show resolved Hide resolved
iphone/plist.txt Outdated Show resolved Hide resolved
data/categories.txt Outdated Show resolved Hide resolved
data/categories.txt Outdated Show resolved Hide resolved
data/categories.txt Outdated Show resolved Hide resolved
data/categories.txt Outdated Show resolved Hide resolved
data/categories.txt Outdated Show resolved Hide resolved
data/categories.txt Outdated Show resolved Hide resolved
data/categories.txt Outdated Show resolved Hide resolved
data/categories.txt Outdated Show resolved Hide resolved
data/categories.txt Outdated Show resolved Hide resolved
data/categories.txt Outdated Show resolved Hide resolved
@j13m126 j13m126 force-pushed the hindi-strings branch 2 times, most recently from 14ab757 to 013998d Compare September 4, 2023 15:17
@j13m126
Copy link
Contributor Author

j13m126 commented Sep 4, 2023

  1. Looks like there are many missing translations for types (e.g. Industrial Area, National Park...) and the app's interface. Were they lost accidentally, or it is just a work in progress?

    1. The search does not work. At least [[Search categories]] section in strings.txt should be translated and match categories.txt translations.

    2. Does it work on Android?

    3. The last commit misses DCO.

Alright, I added a few interface strings, translated search categories and made sure they match categories.txt translations.
I could copy a bunch of interface strings from bing maps by comparing the hindi and english version. I double checked every word with google translate in order not to copy the wrong word.

I tested in on my Pixel 6, running Android 14. Switching phones and also the apps language. I could also enable and hear TTS in hindi. But only on my phone, not on my samsung s6 lite tablet (Android 13). Hindi wasn't an option there.

Countries etc. in the map download section are currently not showing the hindi names, even though I provided some in countries_names.txt.

If you need any more important interface strings, let me know, otherwise I'd like to leave it as is.

@j13m126
Copy link
Contributor Author

j13m126 commented Oct 14, 2023

rebased

@rtsisyk rtsisyk added this to the Next Release milestone Nov 23, 2023
@rtsisyk
Copy link
Member

rtsisyk commented Dec 29, 2023

Let's finish and merge this PR. Could you please re-base it again?

@Jean-BaptisteC
Copy link
Contributor

Rebase is not enough :(
Can you rebase and regenerate strings?

@j13m126 j13m126 force-pushed the hindi-strings branch 2 times, most recently from d95fada to 27a20a2 Compare January 14, 2024 21:44
@j13m126
Copy link
Contributor Author

j13m126 commented Jan 14, 2024

Rebase is not enough :( Can you rebase and regenerate strings?

Right, I forgot. Thanks!

@Jean-BaptisteC
Copy link
Contributor

@biodranik ready to merge
@j13m126 thanks for your patience :)

@biodranik
Copy link
Member

biodranik commented Jan 14, 2024

@vng PTAL and merge if it's ok with a postfix if necessary.

Running categories_test.cpp::CategoriesIndex_AllCategories
Number of nodes in the CategoriesIndex trie: 662233
FAILED
indexer_tests/categories_test.cpp:318 TEST(index.GetNumTrieNodes() < 650000) 662233 650000 
Test took 8475 ms

Copy link
Member

@biodranik biodranik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for such a great contribution!

Copy link
Member

@vng vng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure that regenerated strings are ok here?

  • I don't see android strings file
  • iOS localization file has a lot of English strings

j13m126 and others added 2 commits January 16, 2024 01:27
Signed-off-by: Lukas Kronberger <j13m126@posteo.de>

[strings] Fixed mistake with he

Signed-off-by: Alexander Borsuk <me@alex.bio>

[strings] Regenerated hi for iOS

Signed-off-by: Alexander Borsuk <me@alex.bio>
Signed-off-by: Alexander Borsuk <me@alex.bio>
@biodranik
Copy link
Member

@Jean-BaptisteC can you please check if Hindi is working on Android, and also check if each of the search categories works (categories.txt matches types_strings.txt)?

@Jean-BaptisteC
Copy link
Contributor

Translations and searches in Hindi works on Android

Signed-off-by: Alexander Borsuk <me@alex.bio>
@biodranik biodranik merged commit 394d7d0 into organicmaps:master Jan 16, 2024
16 checks passed
@biodranik
Copy link
Member

@j13m126 thank you for your work! There are still many untranslated strings left. Can you please review the strings.txt file again and add the missing translations? Or build OM from source and see which names are not yet translated?

@j13m126
Copy link
Contributor Author

j13m126 commented Jan 16, 2024

Sure, I'll have a look at it. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants