Skip to content

Conversation

@Usland123
Copy link
Contributor

mainly spelled kyiv oblast

Signed-off-by: Usland123 <72984028+Usland123@users.noreply.github.com>
@Jean-BaptisteC
Copy link
Contributor

@biodranik
Copy link
Member

Many people are typing Kiev in the search. After this change the map region won't be found, right?

@Usland123
Copy link
Contributor Author

Usland123 commented Mar 12, 2024

Many people are typing Kiev in the search. After this change the map region won't be found, right?

Kyiv is spelled Kyiv in the app, but the region is spelled Kiev Oblast, so it's even more confusing. what's more, the region is spelled Kyiv Oblast on the map, but in the menu spelled Kiev Oblast

@biodranik
Copy link
Member

The main goal is for the search to work with any variant. AFAIR typos are not supported in the Download search.

@pastk
Copy link
Contributor

pastk commented Mar 13, 2024

Looks like those strings are not used for the search anyway.
E.g. when I search for "kiev" in the downloader in returns completely unrelated results (no "Kiev Oblast").
When I search for "kyiv" it returns "Kiev Oblast" (likely because there is an association with the city of Kyiv via a different data file).

So this change is fine per se.

Making it searchable via "Kiev" should be done elsewhere (any ideas?).

@biodranik
Copy link
Member

Typing "Kiev" shows a correct map for me on iOS master. Is it an Android search bug?

@pastk
Copy link
Contributor

pastk commented Mar 13, 2024

android master:

Screenshot_20240313-230457.jpg

@vng
Copy link
Member

vng commented Mar 13, 2024

Search works with OSM data, not translations.

@vng vng merged commit 83311ca into organicmaps:master Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants