-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Fix Vulkan diagnostics #7618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Vulkan diagnostics #7618
Conversation
biodranik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! A few questions.
android/app/build.gradle
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These files are downloaded by a script, right? Does it make sense to always exclude them from Release builds?
How slow is the debug build with validation enabled?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Validation should not be published by performance reason, it's slow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not an expert in gradle, but it looks like this parameter can't be set for release only. I tried, but it affects on all the flavours.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it can be solved using flavors (e.g. a flavor with validation can be added and both debug and release builds can be tested). We can leave it for later.
meenbeese
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nit. See #7611
4024698 to
2163ac4
Compare
android/app/build.gradle
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it can be solved using flavors (e.g. a flavor with validation can be added and both debug and release builds can be tested). We can leave it for later.
Signed-off-by: renderexpert <expert@renderconsulting.co.uk>
2163ac4 to
51a7b29
Compare
Why:
Vulkan Validation didn't work for a project for a long period. It hid problems in the Vulkan implementation on Android. This PR fixes it by adding a build option to enable Vulkan validation.
Example of output: