color setting for bpp = 8 ?

[espruino-discuss]

Posted at 2018-09-24 by JumJum

As far as I can see, possible bpp values are 1,2,4,8,16,24,32
In set Color bpp of 16,24,32 are handled seperately
All others result in 0 or 0xFFFFFFFF only
Is there a technical reason for that ?

[gfwilliams]

Posted at 2018-09-24 by @gfwilliams

Are you sure about that? Maybe I'm misunderstanding the question.

In 16/24/32 you get R,G and B channels handled separately (if you specify them), but in anything else it's considered that the image is a single channel, so setColor(123) for a BPP of 4 would write the value 123.

[espruino-discuss]

Posted at 2018-09-24 by JumJum

Hmmm, may be I'm misunderstanding the answer.
First, setColor(123) sets color correctly to 123.
Why is setColor(0.5.0.5.0.5) not supported for bpp = 8 ?
If this is on purpose a short hint in description would help.

[gfwilliams]

Posted at 2018-09-24 by @gfwilliams

Ahh, ok - yes, It's not supported because there's no standard way of mapping R,G and B to a single 8 bit value (same with 1, 2 and 4 bits). About the only thing you could reliably assume is white being all 1 and black being all 0 (or vice versa) which is what it does.

I've updated the docs here: espruino/Espruino@8ef686d

If you have some specific display that works another way, nothing stops you from just overriding setColor with your own implementation though...