Espruino JavaScript
Contributing multiple apps as one pull request or multiple #5343
Replies: 1 comment
-
|
Posted at 2022-11-03 by @gfwilliams Hi, that's great! Sorry for not getting back to you sooner! One PR with multiple apps is fine - but if you're changing existing apps I'd really appreciate one PR per app unless the changes are related. If there's an issue it makes it easier to pinpoint and roll back that way.
No problem at all about changing the version - just if it's not the first version it'd be really good to have a ChangeLog file. Posted at 2022-11-03 by user141569 Got it. That makes perfect sense. I forgot about this post and submitted my PR anyways, but luckily I mostly complied with this. I have no changes to other apps to submit at this time, but I might in the future. I'll keep the one pull request per existing app change "rule" in mind. The only thing is I think some of my changelogs are aweful or nonexistent, so I'll have to take a look at that. Depending on the quality of my commit messages, those might end up getting set back to version 0.01. (That should only affect me because I don't think anyone else uses my personal app loader so it will probably only affect me, and I'll know exactly what I'll have to reinstall.) Posted at 2022-11-04 by @gfwilliams I wouldn't worry too much about what's in the changelogs - I think I said on the PR but just |
Beta Was this translation helpful? Give feedback.
-
Posted at 2022-11-02 by user141569
I have developed a few apps, and I'd like to contribute them back to the official app loader. Should I submit one pull request for each app, or a single pull request with all of them?
Additionally, some of them are not on their first version in my own repo. Can I leave it like this, or should I reset them back to version 0.1 before sending them in?
Beta Was this translation helpful? Give feedback.
All reactions