Skip to content

Commit

Permalink
Fix checkstyle errors. Some errors don't make, hence ignored.
Browse files Browse the repository at this point in the history
  • Loading branch information
Orhan Obut committed May 27, 2017
1 parent 14e7cfc commit 2184656
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 11 deletions.
10 changes: 2 additions & 8 deletions checkstyle.xml
Expand Up @@ -17,16 +17,10 @@

<!-- Space after 'for' and 'if' -->
<module name="RegexpSingleline">
<property name="format" value="^\s*(for|if)[^ ]"/>
<property name="format" value="^\s*(for|if)\b[^ ]"/>
<property name="message" value="Space needed before opening parenthesis."/>
</module>

<!-- For each spacing -->
<module name="RegexpSingleline">
<property name="format" value="^\s*for \(.*?([^ ]:|:[^ ])"/>
<property name="message" value="Space needed around ':' character."/>
</module>

<module name="TreeWalker">
<module name="SuppressWarningsHolder" />
<!-- <property name="cacheFile" value="${checkstyle.cache.file}"/> -->
Expand Down Expand Up @@ -139,7 +133,7 @@
<!-- See http://checkstyle.sf.net/config_misc.html -->
<module name="ArrayTypeStyle"/>
<!--module name="FinalParameters"/-->
<module name="TodoComment"/>
<!--<module name="TodoComment"/>-->
<module name="UpperEll"/>
</module>
</module>
Expand Up @@ -20,4 +20,4 @@ public AndroidLogAdapter(FormatStrategy formatStrategy) {
formatStrategy.log(priority, tag, message);
}

}
}
Expand Up @@ -75,7 +75,7 @@ private File getLogFile(String folderName, String fileName) {

File folder = new File(folderName);
if (!folder.exists()) {
// TODO: What if folder is not created, what happens then?
//TODO: What if folder is not created, what happens then?
folder.mkdirs();
}

Expand Down
Expand Up @@ -41,7 +41,7 @@ protected void onCreate(Bundle savedInstanceState) {

Logger.addLogAdapter(new AndroidLogAdapter(formatStrategy));

Logger.addLogAdapter(new AndroidLogAdapter(){
Logger.addLogAdapter(new AndroidLogAdapter() {
@Override public boolean isLoggable(int priority, String tag) {
return BuildConfig.DEBUG;
}
Expand Down

0 comments on commit 2184656

Please sign in to comment.