fix(remote): Fix detection of GitLab merge request sha if commits were squashed - #1043
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1043 +/- ##
==========================================
+ Coverage 41.93% 41.94% +0.01%
==========================================
Files 21 21
Lines 1784 1786 +2
==========================================
+ Hits 748 749 +1
- Misses 1036 1037 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
GitLabMergeRequest::merge_commit()now returns thesquash_commit_shainstead of None if the commits where squashed in the Merge Request.Motivation and Context
In the generation of the changelog commits were not linked to their GitLab MR if the commits were squashed.
This change allows to identify the corresponding GitLab MR independently if the commit in the MR were squashed or not.
How Has This Been Tested?
Unittest added.
Screenshots / Logs (if applicable)
Types of Changes
Checklist: