fix(bump): check the next version against tag_pattern regex - #1070
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1070 +/- ##
==========================================
- Coverage 41.85% 41.79% -0.06%
==========================================
Files 21 21
Lines 1790 1795 +5
==========================================
+ Hits 749 750 +1
- Misses 1041 1045 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hi @orhun |
|
Hey @vasilich6107 Does your workflow still work fine after this? Any tweaks were required? I'm just asking to see if there is anything that I can do to make this easier for you... apologies again. |
|
With input --tag-pattern like [env]/v1.2.3 it started failing with empty output which affected the pipeline. Rollback to 2.8.0 helps. To use v2.10.0 you need to change to |
|
That seems a bit painful 😅 Do you think reverting to the previous behavior makes sense here? I'm not sure which would be the most sensible default. But I guess I'd prefer |
|
As far as it landed several version ago I do not see a need to rollback Maybe some readme mention about previous behavior and options to resolve |
Description
Check the next version against the regex set by
--tag-patternwhen bumping versions.Motivation and Context
closes #1066
How Has This Been Tested?
Locally.
Types of Changes
Checklist: