Skip to content

fix(bump): check the next version against tag_pattern regex - #1070

Merged
orhun merged 1 commit into
mainfrom
fix/initial_version_tag_pattern
Mar 23, 2025
Merged

fix(bump): check the next version against tag_pattern regex#1070
orhun merged 1 commit into
mainfrom
fix/initial_version_tag_pattern

Conversation

@orhun

@orhun orhun commented Mar 2, 2025

Copy link
Copy Markdown
Owner

Description

Check the next version against the regex set by --tag-pattern when bumping versions.

Motivation and Context

closes #1066

How Has This Been Tested?

Locally.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have formatted the code with rustfmt.
  • I checked the lints with clippy.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-commenter

codecov-commenter commented Mar 2, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 41.79%. Comparing base (63129ce) to head (d0b19dc).
Report is 26 commits behind head on main.

Files with missing lines Patch % Lines
git-cliff/src/lib.rs 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1070      +/-   ##
==========================================
- Coverage   41.85%   41.79%   -0.06%     
==========================================
  Files          21       21              
  Lines        1790     1795       +5     
==========================================
+ Hits          749      750       +1     
- Misses       1041     1045       +4     
Flag Coverage Δ
unit-tests 41.79% <0.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vasilich6107

Copy link
Copy Markdown

Hi @orhun
This change was pretty breaking :-)

@orhun

orhun commented Jul 28, 2025

Copy link
Copy Markdown
Owner Author

Hey @vasilich6107
Oh damn, sorry I should have made this more apparent :/ I think I can still update the highlights about this though.

Does your workflow still work fine after this? Any tweaks were required?

I'm just asking to see if there is anything that I can do to make this easier for you... apologies again.

@vasilich6107

vasilich6107 commented Jul 28, 2025

Copy link
Copy Markdown

With input --tag-pattern like [env]/v1.2.3 it started failing with empty output which affected the pipeline.

Rollback to 2.8.0 helps.

To use v2.10.0 you need to change to --tag-pattern "${{ github.event.inputs.environment }}/v[0-9]+\\.[0-9]+\\.[0-9]+"

@orhun

orhun commented Jul 28, 2025

Copy link
Copy Markdown
Owner Author

That seems a bit painful 😅

Do you think reverting to the previous behavior makes sense here? I'm not sure which would be the most sensible default.

But I guess I'd prefer tag_pattern to take affect throughout the whole process of changelog generation.

@vasilich6107

Copy link
Copy Markdown

As far as it landed several version ago I do not see a need to rollback

Maybe some readme mention about previous behavior and options to resolve

orhun added a commit that referenced this pull request Aug 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Initial tag hard coded to 0.1.0, even when it doesn't match tag_pattern

3 participants