feat: recurse into submodules - #1082
Conversation
|
Thanks for opening this pull request! Please check out our contributing guidelines! ⛰️ |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1082 +/- ##
==========================================
- Coverage 41.09% 40.29% -0.79%
==========================================
Files 21 21
Lines 1845 1894 +49
==========================================
+ Hits 758 763 +5
- Misses 1087 1131 +44
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Nice! So for a given commit range of the containing repo, this returns all submodules that changed within those commits, and their deltas between them? |
|
This is actually an improvement and "replaces" some of what I was trying to do, and I'm super happy to see it |
|
Well, this iteration sort of actually works! However, the submodule path is not correct ... I used openstack/openstack for testing btw, that repository does seem like the ultimate stresstest. |
|
So that is fixed as well, only config option, documentation and code cleanup/review are missing. |
|
This is some good stuff. Let me know when this is ready for review :) |
orhun
left a comment
There was a problem hiding this comment.
Looks nice!
Some things to do:
- Add fixture tests to ensure the functionality
- Update documentation about the new configuration option
|
Thanks for the review! I'll have time to address your comments in about a week. |
Co-authored-by: Orhun Parmaksız <orhunparmaksiz@gmail.com>
|
@orhun If CI turns out good (which it should), this is ready for a (hopefully) final review.
|
There was a problem hiding this comment.
Thank you, this looks great! Only a couple of tweaks left:
- I left a review about the fixture configs, they can be simplified.
- Can you update the default config (
config/cliff.toml) and include therecurse_submodulesthere? - Lastly, we need to rebase on
main:)
And sorry for late review, I've been traveling...
|
@orhun addressed your review and fixed conflicts. additionally, the description and title has been updated to make this pr ready for squash merge. |
orhun
left a comment
There was a problem hiding this comment.
Neat feature, thank you very much for your contribution!
|
Congrats on merging your first pull request! ⛰️ |
|
Woohoo, nice! |
|
Any chance to get a new release by Monday? This would really help me at my job. |
|
I was already planning a release soon, I'll try to push it sooner :) |
Usage
If
recurse_submodulesis set totrue, you can include submodule commits into your changelog.For example:
Implementation details
Adds a feature which allows git-cliff to recurse into submodules of a repository. Between two subsequent releseases in the main repository, all submodule commits in between are expanded. For each submodule, there is an entry in
submodule_commitsmapping the submodules path to a list of commits. This feature is off by default (recurse_submodules=false). Nested submodules are not supported.