Skip to content

chore(project): migrate to Rust 2024 edition#1128

Merged
orhun merged 1 commit into
mainfrom
chore/rust-2024-edition
Apr 20, 2025
Merged

chore(project): migrate to Rust 2024 edition#1128
orhun merged 1 commit into
mainfrom
chore/rust-2024-edition

Conversation

@orhun

@orhun orhun commented Apr 20, 2025

Copy link
Copy Markdown
Owner

Description

Migrates the codebase to Rust 2024 edition, see https://blog.rust-lang.org/2025/02/20/Rust-1.85.0/

MSRV is now 1.85.0

Motivation and Context

I'm always on the edge.

How Has This Been Tested?

Locally.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have formatted the code with rustfmt.
  • I checked the lints with clippy.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-commenter

codecov-commenter commented Apr 20, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 40.13%. Comparing base (4a3c0c0) to head (d00ae09).
⚠️ Report is 163 commits behind head on main.

Files with missing lines Patch % Lines
git-cliff/src/main.rs 0.00% 3 Missing ⚠️
git-cliff/src/lib.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1128      +/-   ##
==========================================
- Coverage   40.29%   40.13%   -0.15%     
==========================================
  Files          21       21              
  Lines        1894     1899       +5     
==========================================
- Hits          763      762       -1     
- Misses       1131     1137       +6     
Flag Coverage Δ
unit-tests 40.13% <20.00%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@orhun
orhun force-pushed the chore/rust-2024-edition branch from 69565f8 to 1c5b504 Compare April 20, 2025 20:20
@orhun
orhun force-pushed the chore/rust-2024-edition branch from 1c5b504 to d00ae09 Compare April 20, 2025 20:23
@orhun
orhun merged commit 4445f06 into main Apr 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants