Skip to content

fix: ensure skip_tags condition is evaluated first - #1190

Merged
orhun merged 3 commits into
orhun:mainfrom
ognis1205:fix/issue-1181
Jun 30, 2025
Merged

orhun merged 3 commits into
orhun:mainfrom
ognis1205:fix/issue-1181

Conversation

@ognis1205

@ognis1205 ognis1205 commented Jun 24, 2025 •

Copy link
Copy Markdown
Contributor

Description

This PR refactors the logic that determines whether to skip a tag during changelog generation.
Previously, some skip conditions were nested or not independently evaluated.
Now, all conditions are flattened and evaluated, making the behavior more predictable and consistent.

Motivation and Context

The prior implementation may have skipped tags inconsistently if some conditions short-circuited the evaluation.

Fixes or relates to: #1181

How Has This Been Tested?

  • Added a test fixture.

Screenshots / Logs (if applicable)

N/A

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have formatted the code with rustfmt.
  • I checked the lints with clippy.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@ognis1205
ognis1205 requested a review from orhun as a code owner June 24, 2025 13:03
@codecov-commenter

codecov-commenter commented Jun 24, 2025 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 43.29%. Comparing base (4f7379a) to head (f7dd6b3).
⚠️ Report is 146 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1190      +/-   ##
==========================================
+ Coverage   43.05%   43.29%   +0.24%     
==========================================
  Files          22       22              
  Lines        2056     2054       -2     
==========================================
+ Hits          885      889       +4     
+ Misses       1171     1165       -6     
Flag Coverage Δ
unit-tests 43.29% <100.00%> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

ognis1205

This comment was marked as resolved.

@ognis1205 ognis1205 changed the title fix: ensure all skip_tags conditions are evaluated with OR logic fix: ensure all skip_tags conditions are evaluated first Jun 24, 2025
@ognis1205
ognis1205 force-pushed the fix/issue-1181 branch 2 times, most recently from 15993c0 to f7b6b5a Compare June 24, 2025 20:29
@ognis1205 ognis1205 mentioned this pull request Jun 24, 2025
1 task done
@ognis1205
ognis1205 force-pushed the fix/issue-1181 branch 3 times, most recently from 1b135c1 to 06616e5 Compare June 25, 2025 11:12
@ognis1205 ognis1205 changed the title fix: ensure all skip_tags conditions are evaluated first fix: ensure skip_tags condition is evaluated first Jun 25, 2025
Signed-off-by: Shingo OKAWA <shingo.okawa.g.h.c@gmail.com>
Signed-off-by: Shingo OKAWA <shingo.okawa.g.h.c@gmail.com>
…s regarding rebase

Signed-off-by: Shingo OKAWA <shingo.okawa.g.h.c@gmail.com>

@orhun orhun left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thanks for the fix!

I'm just wishing for no side effects 🤞🏼

@orhun
orhun merged commit 318be66 into orhun:main Jun 30, 2025
@ognis1205

Copy link
Copy Markdown
Contributor Author

Looking good, thanks for the fix!

I'm just wishing for no side effects 🤞🏼

Absolutely — I feel the same. 🤞🏼
If anything unexpected comes up, I’m more than happy to help fix it and take responsibility.

@ognis1205
ognis1205 deleted the fix/issue-1181 branch November 4, 2025 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants