fix: ensure skip_tags condition is evaluated first - #1190
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1190 +/- ##
==========================================
+ Coverage 43.05% 43.29% +0.24%
==========================================
Files 22 22
Lines 2056 2054 -2
==========================================
+ Hits 885 889 +4
+ Misses 1171 1165 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ognis1205
force-pushed
the
fix/issue-1181
branch
from
June 24, 2025 13:48
79c4f83 to
fbb8b21
Compare
ognis1205
force-pushed
the
fix/issue-1181
branch
2 times, most recently
from
June 24, 2025 20:29
15993c0 to
f7b6b5a
Compare
1 task done
ognis1205
force-pushed
the
fix/issue-1181
branch
3 times, most recently
from
June 25, 2025 11:12
1b135c1 to
06616e5
Compare
Signed-off-by: Shingo OKAWA <shingo.okawa.g.h.c@gmail.com>
Signed-off-by: Shingo OKAWA <shingo.okawa.g.h.c@gmail.com>
ognis1205
force-pushed
the
fix/issue-1181
branch
from
June 28, 2025 14:07
3675adc to
e9ce108
Compare
…s regarding rebase Signed-off-by: Shingo OKAWA <shingo.okawa.g.h.c@gmail.com>
orhun
approved these changes
Jun 30, 2025
orhun
left a comment
Owner
There was a problem hiding this comment.
Looking good, thanks for the fix!
I'm just wishing for no side effects 🤞🏼
Contributor
Author
Absolutely — I feel the same. 🤞🏼 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the logic that determines whether to skip a tag during changelog generation.
Previously, some skip conditions were nested or not independently evaluated.
Now, all conditions are flattened and evaluated, making the behavior more predictable and consistent.
Motivation and Context
The prior implementation may have skipped tags inconsistently if some conditions short-circuited the evaluation.
Fixes or relates to: #1181
How Has This Been Tested?
Screenshots / Logs (if applicable)
N/A
Types of Changes
Checklist: