Skip to content

Conversation

@bukowa
Copy link
Contributor

@bukowa bukowa commented Jun 13, 2024

Motivation and Context

Undocumented 2.0 change https://git-cliff.org/blog/2.0.0#-bump-improvements
Fixes #692

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have formatted the code with rustfmt.
  • I checked the lints with clippy.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: Bukowa <gitbukowa@gmail.com>
@bukowa bukowa requested a review from orhun as a code owner June 13, 2024 00:28
@welcome
Copy link

welcome bot commented Jun 13, 2024

Thanks for opening this pull request! Please check out our contributing guidelines! ⛰️

@codecov-commenter
Copy link

codecov-commenter commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.89%. Comparing base (8a9f9f4) to head (6b4fdb3).
Report is 236 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #695   +/-   ##
=======================================
  Coverage   36.89%   36.89%           
=======================================
  Files          18       18           
  Lines        1350     1350           
=======================================
  Hits          498      498           
  Misses        852      852           
Flag Coverage Δ
unit-tests 36.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Owner

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@orhun orhun merged commit 4cd18c2 into orhun:main Jun 13, 2024
@welcome
Copy link

welcome bot commented Jun 13, 2024

Congrats on merging your first pull request! ⛰️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Defining Pre-Release Versions: Beta, Alpha, RC, and Version Bumping (--bump)

3 participants