Skip to content

feat(args): add --ignore-tags argument#696

Merged
orhun merged 15 commits intoorhun:mainfrom
bukforks:ignore_tags-arg
Jun 17, 2024
Merged

feat(args): add --ignore-tags argument#696
orhun merged 15 commits intoorhun:mainfrom
bukforks:ignore_tags-arg

Conversation

@bukowa
Copy link
Contributor

@bukowa bukowa commented Jun 13, 2024

Description

This adds --ignore-tags argument to cli.

How Has This Been Tested?

I included fixture based tests but - this fixture won't pass - because of this line
I am not sure if this is intended - I would expect this to work (not requiring a commit to recognize 1.0.0 version) - need more info.
If this is intended then simply need to uncomment this line.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have formatted the code with rustfmt.
  • I checked the lints with clippy.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

bukowa added 5 commits June 14, 2024 00:25
Signed-off-by: Bukowa <gitbukowa@gmail.com>
Signed-off-by: Bukowa <gitbukowa@gmail.com>
Signed-off-by: Bukowa <gitbukowa@gmail.com>
This reverts commit f307647.

Signed-off-by: Bukowa <gitbukowa@gmail.com>
Signed-off-by: Bukowa <gitbukowa@gmail.com>
@bukowa bukowa requested a review from orhun as a code owner June 13, 2024 23:02
…re-tags/commit.sh

Signed-off-by: Bukowa <gitbukowa@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Jun 13, 2024

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 36.18%. Comparing base (dabe716) to head (969b884).
⚠️ Report is 275 commits behind head on main.

Files with missing lines Patch % Lines
git-cliff/src/lib.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #696      +/-   ##
==========================================
- Coverage   36.29%   36.18%   -0.11%     
==========================================
  Files          19       19              
  Lines        1455     1457       +2     
==========================================
- Hits          528      527       -1     
- Misses        927      930       +3     
Flag Coverage Δ
unit-tests 36.18% <0.00%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

bukowa

This comment was marked as outdated.

Signed-off-by: Bukowa <gitbukowa@gmail.com>
bukowa added 5 commits June 15, 2024 19:41
Signed-off-by: Bukowa <gitbukowa@gmail.com>
Signed-off-by: Bukowa <gitbukowa@gmail.com>
Signed-off-by: Bukowa <gitbukowa@gmail.com>
This reverts commit c829865.

Signed-off-by: Bukowa <gitbukowa@gmail.com>
Signed-off-by: Bukowa <gitbukowa@gmail.com>
Copy link
Contributor Author

@bukowa bukowa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I merged main I hope its ok. I can revert if needed.

Copy link
Owner

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@orhun orhun changed the title feat(cli,args): add --ignore-tags argument to cli feat(args): add --ignore-tags argument Jun 17, 2024
@orhun orhun merged commit 94891c2 into orhun:main Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants