feat(args): add --ignore-tags argument#696
Merged
orhun merged 15 commits intoorhun:mainfrom Jun 17, 2024
Merged
Conversation
Signed-off-by: Bukowa <gitbukowa@gmail.com>
Signed-off-by: Bukowa <gitbukowa@gmail.com>
Signed-off-by: Bukowa <gitbukowa@gmail.com>
This reverts commit f307647. Signed-off-by: Bukowa <gitbukowa@gmail.com>
Signed-off-by: Bukowa <gitbukowa@gmail.com>
…re-tags/commit.sh Signed-off-by: Bukowa <gitbukowa@gmail.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #696 +/- ##
==========================================
- Coverage 36.29% 36.18% -0.11%
==========================================
Files 19 19
Lines 1455 1457 +2
==========================================
- Hits 528 527 -1
- Misses 927 930 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Bukowa <gitbukowa@gmail.com>
orhun
reviewed
Jun 15, 2024
1 task
Signed-off-by: Bukowa <gitbukowa@gmail.com>
Signed-off-by: Bukowa <gitbukowa@gmail.com>
Signed-off-by: Bukowa <gitbukowa@gmail.com>
This reverts commit c829865. Signed-off-by: Bukowa <gitbukowa@gmail.com>
Signed-off-by: Bukowa <gitbukowa@gmail.com>
orhun
reviewed
Jun 15, 2024
bukowa
commented
Jun 17, 2024
Contributor
Author
bukowa
left a comment
There was a problem hiding this comment.
I merged main I hope its ok. I can revert if needed.
--ignore-tags argument to cli--ignore-tags argument
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds
--ignore-tagsargument to cli.How Has This Been Tested?
I included fixture based tests but - this fixture won't pass - because of this line
I am not sure if this is intended - I would expect this to work (not requiring a commit to recognize 1.0.0 version) - need more info.
If this is intended then simply need to uncomment this line.
Types of Changes
Checklist: