Merged
Conversation
|
Thanks for opening this pull request! Please check out our contributing guidelines! ⛰️ |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #709 +/- ##
==========================================
+ Coverage 36.66% 37.04% +0.38%
==========================================
Files 20 20
Lines 1544 1531 -13
==========================================
+ Hits 566 567 +1
+ Misses 978 964 -14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
12 tasks
orhun
reviewed
Jun 16, 2024
orhun
reviewed
Jun 16, 2024
orhun
reviewed
Jun 16, 2024
orhun
reviewed
Jun 16, 2024
orhun
reviewed
Jun 16, 2024
Owner
orhun
left a comment
There was a problem hiding this comment.
Thanks for this! It mostly looks good, the behavior looks like the same. I have some concerns about lib.rs but will double check to make sure.
Co-authored-by: Orhun Parmaksız <orhunparmaksiz@gmail.com>
Contributor
Author
|
@orhun should be good now 🙏 |
orhun
reviewed
Jun 25, 2024
|
Congrats on merging your first pull request! ⛰️ |
Owner
|
Awesome work, thanks a lot! |
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Some clean up opportunities I found while reading the code.
No functional changes intended.
Please let me know if breaking changes are a concern for you, I can revert the change to the public API in the core crate.
Motivation and Context
Refactor
How Has This Been Tested?
cargo test+cargo clippyScreenshots / Logs (if applicable)
Types of Changes
Checklist: