fix(template): resolve parsing issues with raw/endraw in Jinja#824
Merged
orhun merged 1 commit intoorhun:mainfrom Aug 29, 2024
pplmx:main
Merged
fix(template): resolve parsing issues with raw/endraw in Jinja#824orhun merged 1 commit intoorhun:mainfrom pplmx:main
raw/endraw in Jinja#824orhun merged 1 commit intoorhun:mainfrom
pplmx:main
Conversation
…evel callers using the Jinja engine
|
Thanks for opening this pull request! Please check out our contributing guidelines! ⛰️ |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #824 +/- ##
=======================================
Coverage 40.19% 40.19%
=======================================
Files 20 20
Lines 1645 1645
=======================================
Hits 661 661
Misses 984 984
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
raw and endraw prevent correct parsing by higher-level callers using the Jinja engineraw/endraw in Jinja
|
Congrats on merging your first pull request! ⛰️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request removes the usage of
{% raw %}and{% endraw %}tags from the template files. The presence of these tags caused parsing issues for higher-level callers that also utilize the Jinja engine.Motivation and Context
The change is necessary because using
{% raw %}and{% endraw %}tags can interfere with the correct parsing of templates by higher-level callers using the Jinja engine. This modification ensures compatibility and proper parsing for all Jinja-based template users. This PR addresses an issue where templates could not be parsed correctly due to the conflict caused by these tags.closes #818
How Has This Been Tested?
Tested.
Screenshots / Logs (if applicable)
N/A
Types of Changes
Checklist: