NPM option parsing improvements and documentation improvements#843
Merged
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #843 +/- ##
==========================================
+ Coverage 40.13% 40.19% +0.07%
==========================================
Files 20 20
Lines 1645 1645
==========================================
+ Hits 660 661 +1
+ Misses 985 984 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
This should be merged with "rebase & merge" to retain proper conventional commit history for the changelog generation
Description
Couple of changes bundled:
skip-commitin cliff-jumper. Because the appropriate syntax forgit-cliffis--skip-commit SHA --skip-commit SHA --skip-commit SHA --skip-commit SHA <options options>it is more ideal if the NodeJS code optionally takes an array of commits which can easily be parsed to CLI args in the library as opposed to janking something in cliff-jumper.Optionstype so I added them.--gitea-repositorymentioned GitLab and adjusted it accordingly.Motivation and Context
As mentioned above, I got the request to implement
--skip-commitin cliff-jumper and needed a change for that.How Has This Been Tested?
I ran
yarn buildinnpm/git-cliffthenyarn packto create apackage.tgzwhich I then installed incliff-jumperThis is when providing an array of strings:
Screenshots / Logs (if applicable)
Types of Changes
Checklist: