chore(ci): check pedantic lints#853
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #853 +/- ##
=======================================
Coverage 39.94% 39.94%
=======================================
Files 20 20
Lines 1660 1660
=======================================
Hits 663 663
Misses 997 997
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Oops, there seems to be a lot of lints :D I guess it's fine to ignore some of them for now. |
|
Yes :) For that reason, I split the nice checks into multiple MRs instead of solving them in one MR. I will ignore some of them. I still have around 15 checks left on my TODO list. Is it okay with you if I continue with them using the workflow I had before (each check is in a separate MR)? When I finish with them, I can ping you, and we can decide what to do with the rest of them. We can also ignore the rest of the checks in the pedantic CI check. |
|
Yup, sounds good, as long as we don't exaggerate things a lot :) I don't like all the pedantic lints tbh, the ones you sent were reasonable so far. |
Description
Add pedantic lints checking to the CI and do not fail the CI if warnings exist.
Motivation and Context
It is good to have some reports about pedantic errors at the merging level, especially in pull requests. Now, users can see the quality of their code on a pedantic linter level.
We are currently resolving many pedantic errors in the existing code in the other MR.
How Has This Been Tested?
I tested the command manually in the terminal.

I tested the CI in that pull request. If the build passes and we have an extra step in the Lints job with pedantic warnings, that means we have configured the CI correctly.
Types of Changes
Checklist: